From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 982FF2D6E44 for ; Wed, 13 May 2026 18:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778697234; cv=none; b=Qi93Nd7A3QBAqaXG3c7Z8j4tvo55PSF+pdTPIFmCzIkTo87S7TIaP43udtk5prjV5yXLA2LvQd016ps3kQRZG5h8Ur0guUpm3fmhWqEY6QPlhAXEb5c9YE+CVl/EqtTYz0SeasXhsaMlHctWx2UbYCN2KTr6jk4sFnQhgy7bX8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778697234; c=relaxed/simple; bh=MU20TOvr9sTBX6bUmd9qWSI/ecCxRjPKCFo+Kdr4A9g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JkSFLA6vtr4cT8TmvyNQaRXZobcx+RazrBfmZfYPs4LiieyE0bLhWnG6FdRSH5+ip76C0+oPXlBRfWzDwe8fGdJ/rjEIeL2Se8HtLSO6eMnygZbhDNdDpszIn9Ar/3Em/gr0I1niP/QbPTZhoiDm+aYIkp7nI9NuNHn4F6bvu+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SA+G65Xh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SA+G65Xh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB031C19425; Wed, 13 May 2026 18:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778697234; bh=MU20TOvr9sTBX6bUmd9qWSI/ecCxRjPKCFo+Kdr4A9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SA+G65XhYZLCJA5q6TnH82kzDJPDRK1Kc0skQGDQw1pMmMdDGXEtJn5hh0qakNBYJ oM5SaceHEfpslvoTMPFc7ByPs16ol+L+NwA+4B8qBaHKJcI5DJZqAURwHNV+8A23yG 6JFP85bJitwbAXd/M1m7NTLy4DdgJVxXNpl1ioAXpQK3XTJpdCd09PAWWo1ox+ShYG vKkH9jsLS62QOtd0tZy9vwVcoUjDfZ2yeQOevv37DOjH+k6KnDzRUV0mLFJsaYVgWA bbWsxHoVZhJtJcmFUEHeI+v+LaAkep+GGjXjUoj/R2o7S3t+7mjz71TJiT/bw1eDjI /4zsYjf3NyWfg== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Masahisa Kojima , Mark Brown , Sasha Levin Subject: [PATCH 5.10.y] spi: syncuacer: fix controller deregistration Date: Wed, 13 May 2026 14:33:51 -0400 Message-ID: <20260513183351.3927329-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051242-fax-huddle-8d32@gregkh> References: <2026051242-fax-huddle-8d32@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit 75d849c3452e9611de031db45b3149ba9a99035f ] Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b0823ee35cf9 ("spi: Add spi driver for Socionext SynQuacer platform") Cc: stable@vger.kernel.org # 5.3 Cc: Masahisa Kojima Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-21-johan@kernel.org Signed-off-by: Mark Brown [ renamed spi_controller/host to spi_master/master and kept int return type with `return 0;` ] Signed-off-by: Sasha Levin --- drivers/spi/spi-synquacer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c index dc188f9202c97..4422fe9d92ff9 100644 --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -719,7 +719,7 @@ static int synquacer_spi_probe(struct platform_device *pdev) pm_runtime_set_active(sspi->dev); pm_runtime_enable(sspi->dev); - ret = devm_spi_register_master(sspi->dev, master); + ret = spi_register_master(master); if (ret) goto disable_pm; @@ -740,10 +740,16 @@ static int synquacer_spi_remove(struct platform_device *pdev) struct spi_master *master = platform_get_drvdata(pdev); struct synquacer_spi *sspi = spi_master_get_devdata(master); + spi_master_get(master); + + spi_unregister_master(master); + pm_runtime_disable(sspi->dev); clk_disable_unprepare(sspi->clk); + spi_master_put(master); + return 0; } -- 2.53.0