From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99706352C2B for ; Wed, 13 May 2026 18:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778697245; cv=none; b=mHfFWTFLBHSkwr7DiUHj64J/JrzXyRonBVh3aTI4EKg38Nn+Ftqni78RHw8fZFv2f2W2AREZch936wlexgLFjT5uzn/BRX6pS+W1lswhZPxo5mWKYX5Eg/wWUkqgGY3Y6wLUoZepWRvWFN38BGMJU+0+JN1mS16Y9chJnZ5uaVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778697245; c=relaxed/simple; bh=ECUfdJOF5sx/Lwk+jawY2WKGn7NqF+yoSu6V1IYz4UI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GiBlFtdE3O7V3O0I4Z8+gAi7iPEIvnX/HHhDkXhvk0upB+W+79le5jAZrkOLB2NihjheWbWSetoDce2gLnuk530MQKpdaSfGoFbJ/IPD01uqPAdpOiK6Bg3XkXBUzjAgyeRjw/qJITTLFqzGkw9gIrAFpHA/6yuTydutGMsbUEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aisMIBI7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aisMIBI7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2EB4C19425; Wed, 13 May 2026 18:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778697245; bh=ECUfdJOF5sx/Lwk+jawY2WKGn7NqF+yoSu6V1IYz4UI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aisMIBI7B6GkvO4NvWqcytwdM8sk3lBUksvv34WNrSOY0CwFMqKL+0jhSRs52ywog 1vOgrFAW+2yYTeSFQZ8TocDLx8J5t3EJxvuXUjabbJL6dJH9JUJ2pNJEvQnwNHnUji U4azEnZdO6pmEaX0vvY+OCgFlXg+ni72j3jhi1MM2Rnc+oUebCyvg0U3gyrns/+SdE 176JayJ2dxoLrzHxyCK7ghHFf4D8RgJrn2GZ57Nsuua0rLiUFSjVL+sC3LFWafquqZ zzfHDY/ZzIZsuRcRMaImtYExpQAJDASH11+zcumY7i2d9UVu2e4HJUOvDLYwZ4R/3n 04IrwJLjJPCig== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Maxime Ripard , Mark Brown , Sasha Levin Subject: [PATCH 5.10.y] spi: sun4i: fix controller deregistration Date: Wed, 13 May 2026 14:34:01 -0400 Message-ID: <20260513183401.3927454-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051253-fabric-rocky-e5b7@gregkh> References: <2026051253-fabric-rocky-e5b7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit 42108a2f03e0fdeabe9d02d085bdb058baa1189f ] Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b5f6517948cc ("spi: sunxi: Add Allwinner A10 SPI controller driver") Cc: stable@vger.kernel.org # 3.15 Cc: Maxime Ripard Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-19-johan@kernel.org Signed-off-by: Mark Brown [ renamed `host`/`spi_controller` to `master`/`spi_master` and kept `int` return type with `return 0` in remove ] Signed-off-by: Sasha Levin --- drivers/spi/spi-sun4i.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index a8fba310d7004..ab99cc7438652 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -503,7 +503,7 @@ static int sun4i_spi_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); pm_runtime_idle(&pdev->dev); - ret = devm_spi_register_master(&pdev->dev, master); + ret = spi_register_master(master); if (ret) { dev_err(&pdev->dev, "cannot register SPI master\n"); goto err_pm_disable; @@ -521,8 +521,16 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { + struct spi_master *master = platform_get_drvdata(pdev); + + spi_master_get(master); + + spi_unregister_master(master); + pm_runtime_force_suspend(&pdev->dev); + spi_master_put(master); + return 0; } -- 2.53.0