From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E87CD3CEB9E for ; Wed, 13 May 2026 23:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778715542; cv=none; b=bUkK1v9HNQebQQnX2tHWeAW+q1n8+FVNpAR0E10+hpUm5d7ikkl0ONuKxLxBIwGXmq9HH9TSuFGzdEXK/+ipvFiBgtdIf6fm90azlBzOrL6PCRCdeQMgn7r5QDNoWko7bYcT/ug343uyf2n/XmH2QQNK34R2nX0x+ya2bYI0l/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778715542; c=relaxed/simple; bh=yNFOqidkRBNgkU5BEct5DiEOH0XxS4aqc8GDnXCUja0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p4Waj1BqY6NlV5pYz7/xKHV/P1FFo4R2O8PttHlNn3TZdbZLij6+VxjaVbYXst4K3A52lLS6yiQSFX5ah9Vz4U59guNqzqccNIph228VOXuGpYMM+lklpn6JD9X4hqPFnn/tOm49zlXEH6Uew0UEVoMVWlAwciBl4M9dZCtCTcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=elMU24co; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="elMU24co" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-8eab809593cso788239185a.3 for ; Wed, 13 May 2026 16:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778715540; x=1779320340; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kyfRQ0H0Q6NSd7lYeTh8kpqekVQ9G1te4Gf1oV/71tU=; b=elMU24coeIHXMqBgbRYYf6anFYgmVnSA3S+27luLUM0gYZRLVSgK9ik4sRb3WI6oia z9n12yHQdl+kDGNqWkbDbW5tjzHr8o3E10x1Kvn8FTlyBM02RVNSyG49orENp5LZ2giG vpNkIznedJzcFUah7M8dYCIwbas+N11dcaZOqyzzE3L6EmLUZNTGbxCCkzSaCg+1RMtw dNMjk5EyMgLf30de2UzfPHGLm3kxH7Z5TIqqEcXwHgkqZthDAOd7qr29lQ8TTIFR4dYs RnpKUMPCMdQRLK6FnE8anGcZrtxctCJritwl6Gnbf4fCVKbafa9par3UnT/LOV29cdOd QUGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778715540; x=1779320340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kyfRQ0H0Q6NSd7lYeTh8kpqekVQ9G1te4Gf1oV/71tU=; b=IQ3VuQBnDqFDjsOwT0d2UqZhx0owvkHi4uyxsmpiot8j3bmk7pc08wGUL1JFB9itKx 5+pfkiCHBpy9bn/sCxHNNf6QNPVPGQIBDu7IRY0ev3gjwMHPuZECtKqOpIJ/Mdio22z4 cV9EZmjdddfVYzmTw1+Rki/NfW9/4mn5MlQIcYS7a+cVl9k01ga2AkxljXaNOr8QnDd6 Dtzw/QkgDRX9NdsDRiROXYK3Yt8L6uOLx5WTWlplYMSsv8J2Y9ESEijiGZavwi/Lty+f lrNQLwsOdt9qFfFT6LEzhyyjFMLjt4ctTr1Ppsm5IN2ySRTPqmSzzgsdAb2fAFk+C5ay GheA== X-Forwarded-Encrypted: i=1; AFNElJ8CbrRLDvm7nW3OARJqyhdah0AsEWoWcKfJMO5NcXfkuMZsc2Z6remfELuJ1FhmgMdEUczvw1w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2SLvEf8MfNLxLBecWU5tSeuQG0cV9VgBbZw88xsKOMznMMXMI 1aBvC08VFcbelZKGu4r2IMWNIyHKwFeH3Ep3yH20aNwzCWpSrbLFne5Z X-Gm-Gg: Acq92OFO6kC/76Avp+l2ngiqZIzI0Ca/LWIe2WnU/qWTsawD9McZtEHuzNfEKJeXcot lH+NmpRd7by1YsmyyDkbNCSSc+cUkih4/4cKqGAvZVm995ZVICNL8NnfMX28Dfv3kU8dr9rjJoO OJcQQ1uF836kMpMxFVJ+dPIe2Jo7L8Tmmum2x+OeDOLxt2Eahj3dPvyKdeeFmlfBrax/q8iMGwK SW1pWCTOBS9oOpNOZOuuetuprwaVZ0Q1dR0AvyR0NUkaY8Rmm9TjD00IpbYxlbhN4q8mBYCRqDv obGdXhcn6nWrQ9XmSJJc7YLZAWFZndJuXSvm5WAKvF1zKY0qL7sdZipHHsJB2mRCV8FvXujQl1N 37nzthJDivhdOH03JvO08R32/JB6Wt4UF1kj9U4Iu0qXPScixsbkSAE9sbOROwaLC6nBnzXSYhl 9Z4znhyjFmXZA3lQ/BNDATMYk2B8z302qdeUHZwJilNfbcnEjKiU68oVlhUw/cXAcsNvcMx4ur/ CHqQKJgDJUx5EHqJXNXIPyLueUog0x5XwEwELCsdgauPCvLu6fokg== X-Received: by 2002:a05:620a:4155:b0:8f4:3895:25d7 with SMTP id af79cd13be357-90f88d9aeb1mr853891985a.23.1778715535171; Wed, 13 May 2026 16:38:55 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910baf2236fsm94186085a.20.2026.05.13.16.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 16:38:54 -0700 (PDT) From: Michael Bommarito To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org Cc: Felix Maurer , Sebastian Andrzej Siewior , Luka Gejak , Cong Wang , Kexin Sun , stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/1] net: hsr: defer node table free until after RCU readers Date: Wed, 13 May 2026 19:38:38 -0400 Message-ID: <20260513233838.3064715-2-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260513233838.3064715-1-michael.bommarito@gmail.com> References: <20260513233838.3064715-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit HSR node-list and node-status generic-netlink operations run under rcu_read_lock(). They walk hsr->node_db through hsr_get_next_node() and hsr_get_node_data(), but RTM_DELLINK teardown removes the same node table with plain list_del() and frees each node immediately. That lets a generic-netlink reader hold a struct hsr_node pointer across hsr_dellink(). In a KASAN build, widening the reader window after hsr_get_next_node() obtains the node reproduces a slab-use-after-free when the reader copies node->macaddress_A; the freeing stack is hsr_del_nodes() from hsr_dellink(). Use list_del_rcu() and defer the free through the existing hsr_free_node_rcu() callback. This matches the lifetime rule used by the HSR prune paths, which already delete nodes with list_del_rcu() and call_rcu(). Fixes: b9a1e627405d ("hsr: implement dellink to clean up resources") Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Michael Bommarito Assisted-by: Claude:claude-opus-4-7 --- net/hsr/hsr_framereg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index d09875b33588..06b0977ab099 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -163,8 +163,8 @@ void hsr_del_nodes(struct list_head *node_db) struct hsr_node *tmp; list_for_each_entry_safe(node, tmp, node_db, mac_list) { - list_del(&node->mac_list); - hsr_free_node(node); + list_del_rcu(&node->mac_list); + call_rcu(&node->rcu_head, hsr_free_node_rcu); } } -- 2.53.0