From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D3943CDBAB for ; Wed, 13 May 2026 23:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778716513; cv=none; b=fQDcg5Ovd5RpVqyhog+/jqFfuBjaDOazBvvzJiQiLWt7ZWwwfHa0qY8haUee+rzv0pqPmkxQdrNn0th6AVIV1/hdsDYuvNOHTOgZ5pdf9RTYd8l8+D3XoS03qCYNmaRi2N57lpUuLwp8L+q+Z2ZDwkv92NdJpDHBOxc5SW9hQac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778716513; c=relaxed/simple; bh=bv9X9C6ybvBXVMAO8U6jO4EDYmS8S3AlJGFSYWl4PTw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=eCxy1FunbkUDLb0jUBHXPF0pEU7kLlakUf7YYTLLzo1kY7RXgsdj8zc30zKpvzYbyhphqMEW8/kzAp5ynU7vQKAc5EC8DLSbJpq8ltTn+F0xd+sF8EizmFMdwRFkI4wTLws6xgnl+Od7NH/CW09orQEguYwdSPCvtk/25ouQG9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QZP4Czmp; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QZP4Czmp" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2bcf48850c4so23573995ad.1 for ; Wed, 13 May 2026 16:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778716511; x=1779321311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OP4TJnoSOJJLQkWv+kPmUFMD5Nz5E/Le8rvbutXj/wM=; b=QZP4Czmprg+70LeIkefWK8KJ5Rdl6A1DwNAoyLmv3EToSjYjw8Sg0hdmdJt0APToKg EXkjRg0RHTYngAyRGpHfCeGh/9a3St4gllnyRCXaqB0IvleYy3Vp1+D/vvZeoWl/iph7 uovK2IyZvJX/8jvdy+zqk57LM0/cx0wT21Gnl7rQ5g7runHVvskfcOC+K2CqIHHnzJOD mWhTX8Bl49UhzjANBh34PkrYvXi68uIwj+JQtCwK1qYgbS/57YOR1JnLZKSjAqzqLUfX t5NvCnx6jA8sBSc3u6fRXTb70hSULx2aq1l055uqNGtqR7slNNYHEBcWs3YUsT2YHeYD r+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778716511; x=1779321311; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OP4TJnoSOJJLQkWv+kPmUFMD5Nz5E/Le8rvbutXj/wM=; b=fPdYN84uVNudS6zrN5OQ1oKpUCstgBMzTSTt+wpUX+8FP5aWi66KP4ldedRwxoyM1J MtS8R48bEBgMeXrZuQhUSw3H1lMBizAPZc4KHXTJ49j5IU7wvcya78IdmPU6QQEwN3lv 158oI9ggoXXfPoeV6+NUZcJUfLhJ7K9EUAFBv6JFRlxfOfaqbkUKggXv04DkKMh3SDhg MWhvK/u8hQRthElDxVaPf5dN3sLpW3prp41EJZOZZV+6K4u1YhrkZ+f5JfW+P8ugIz02 xtrh+WqCCpoa5XTcJO/eLhBhg1+JEo6My22MZROPIB2fCL/btYIwMJe2VvTb53g86F/8 igyw== X-Forwarded-Encrypted: i=1; AFNElJ/3cwEe/unhjoBkY2Kq+3ugJiZHhPuh/PT2ifjxm0Fw+eKIqUzljmccZ38qkzWlgBGEp1lRHgI=@vger.kernel.org X-Gm-Message-State: AOJu0YxfBSUeoyZ3WP/Z49gJ8muBRVon1S6dLFS6u0e8XYVa9ehokTkd ZUMWMrLcaX49R3sHu6D3qc8Lkl6Ab+Glf6XR3vi8uSD/uI/SY4YfH+XA X-Gm-Gg: Acq92OFe67FM2dgB2bDrqES+c8rSpeHXqKdHjS9zBB0qiAvhXg9VluXc9d50+2kXLJl 7xGu5+v4UoSZKLFDRi3OtAanhH0/yO1hzwsE1cRb4gSvbjx93P6ATHlzs16q7yZE5hT8nLt0T90 ddtZgO58WFZCJICg4EOCd4Yw6MrCZuWzATU64MFsTXrTf7RQUwpnwPwHihTGW0NyjZnz6xjHpK7 Q0G6rdMwfckBMkTPmEOe3C/M5HKDZPETFmnJiYNcEP9703uENz5ygEm3p4/OYJWiJdZNqHq2vtu +PoY2pJL41m5ibwR6N6YLbSYHF1gaPmgEchciMSd+7huqSuGj30vFTGUnNH+Q/GTgKz3MxbPwLX iIpHg9Qe4S1s+RtX+Sh98fmN1PINqVitft15b+8rWZo9flqOkNc+3hdVdmGjBX2fzDtRJGZbZKw 8F2RwGAS/otBT4+Wg2I2pF6QUETZ5SseWaf9QwZ+WkheG8rVlx2PLkMCBa7doSICAeJfw/5An00 9wg/bHh1dI+jlGm X-Received: by 2002:a17:903:198c:b0:2bc:a577:70c2 with SMTP id d9443c01a7336-2bd276e9861mr67196905ad.31.1778716511277; Wed, 13 May 2026 16:55:11 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([203.194.102.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d235e04sm3739355ad.80.2026.05.13.16.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 16:55:10 -0700 (PDT) From: Moksh Panicker To: linux-media@vger.kernel.org Cc: Moksh Panicker , stable@vger.kernel.org Subject: [PATCH] media: mxl111sf: fix null pointer dereference in mxl111sf_ctrl_msg Date: Wed, 13 May 2026 23:55:02 +0000 Message-Id: <20260513235502.9312-1-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When mxl111sf_ctrl_msg() is called during early probe, state->d may not yet be initialized, causing a null pointer dereference in dvb_usbv2_generic_write() when it accesses d->usb_mutex. Add a null check for d before proceeding with the USB transfer. Fixes: d90b336f3f65 ("[media] mxl111sf: Fix driver to use heap allocate buffers for USB messages") Cc: stable@vger.kernel.org Signed-off-by: Moksh Panicker --- drivers/media/usb/dvb-usb-v2/mxl111sf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c index 870ac3c8b085..9908675c355e 100644 --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c @@ -56,6 +56,9 @@ int mxl111sf_ctrl_msg(struct mxl111sf_state *state, int wo = (rbuf == NULL || rlen == 0); /* write-only */ int ret; + if (!d) + return -ENODEV; + if (1 + wlen > MXL_MAX_XFER_SIZE) { pr_warn("%s: len=%d is too big!\n", __func__, wlen); return -EOPNOTSUPP; -- 2.34.1