From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96391C01 for ; Thu, 14 May 2026 00:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778716920; cv=none; b=a6JfWpJ5TGsrbxxUV66KzYJI9zDxV9Ah1RMmVbfEHPz0S9roAb7Bujsa8TqtO4enc1GmsJ6rUzUbYY0NHn0zd7raOvrww2zasflzA2cPIFZqkc1mWy2VP5ObrDfe7URnSwxPbl/aadqRnqeCJsaj2fD3GGDbCuL1tS6qnhHx78s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778716920; c=relaxed/simple; bh=bv9X9C6ybvBXVMAO8U6jO4EDYmS8S3AlJGFSYWl4PTw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=CzO0UgNtCXwflKLh5RVudpSETA4NPfTMRnTu6m9s4RLKuBD2kPjyhHVCaBfJ9V3D3Fkd9n5mjml1yTo4uIc70CRlPVXmc7v2lW0KVfFdXYyFtLULzSSh4LjVSY0EJo24jbqFpU5Wf10kqXqO4/qzG4t95BbBfzGPpN76nhRiHmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=arjYlFWw; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="arjYlFWw" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bcd730e090so29921645ad.2 for ; Wed, 13 May 2026 17:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778716919; x=1779321719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OP4TJnoSOJJLQkWv+kPmUFMD5Nz5E/Le8rvbutXj/wM=; b=arjYlFWwaFvaJXRCTCwE1CPFHPIyR+rHL1aXqZqHXYtyVFhlgTuip4crmFT6jY9l0B SwPIi8A9o+JP197CyJb1uUd5coRVBSRuLo/BhVRazP6ZfQj5avOSalR/Mfm4Ojhez2VC Rhz/MoWiC66zxv/ENoDb4Z1LNgPpa3SxBXwo/EA5kBmQ2PNfWmNdwwddZ0L2KLH8/lyq AFeQKm2+O0oyrwP1higGVCsV0hdzGzzoTpITEkittFrNGbtrNmryOyJkH2ZHY0PRr+mw vgBhWPQwGX5HTZv/jaMwzFuhZkPLlUcoE9mcNF/ZuKvXrzyhXqqVUt39fs8H5Y+PywN+ isow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778716919; x=1779321719; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OP4TJnoSOJJLQkWv+kPmUFMD5Nz5E/Le8rvbutXj/wM=; b=VFJ7twvzWzHjL9TnmBGZjYQnslBaHFQ6Gft/9tXdPVaFAF09qTfErviWSBQeGn0zMQ zP5tmXJd0sOyNhI6x5K9eOE3cH6peIOovKXoBsHJhIlEF2SzgH/PVtm+/WNXpT2p7DUR SwwJ2d7uD3Fx9G11BDYmKWalcZ4N2fnffa/PgocilL7XNyAjH8ii5cJX3+ttgjYYxAaA X7arNZszB5JxxbI5Vd2eLpUoGVjYdEtlRA2G1i3QeD6hbcu0gsRhKAqXT6AQ1ktBrkQ2 4D9ucVl/FpWx6RsLZQNTcEn9kI5ubZORj9BH260mQqjtqWjzlyXM5abJ7iulxVsyiQ06 ZPCA== X-Forwarded-Encrypted: i=1; AFNElJ888ozTfPQSHratiQ5PmAw34CnRgJRspLcfMCbBF8XxqHGZvYRn3JIPq9h7J58FN2n7wRHxngE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxoky8/0v1Wh7253voBut+acaMXgnjNMGId8dqAR7g+y0Tpi6nX z8h1r5AeZ+W1Uf+MlH2SXm3huAxjYOAv3u0jAUjYY+L0IcqJ/vG2dW9W/Kser66l X-Gm-Gg: Acq92OFFx8ub1AtZyIzTNgLhHpm7Zja35NecYdAwGHCa3mto0TXUagcHPs3lNtnd6n+ ec2TCFAE1r68EkSVppWTMOj8vd6QylfaCg8UjPob5Bhjgu19lrWFHjL92L1MpF8FFQ4raDcT0l1 er9ZTBlR1dqMjKhCRBJ+6gwEvZbjCbLgE7M38KVHF69U63LLcWNrsoiIkk/Re+TzE6LRNxGfYlk dnLSqz/8+usOqLx6CPvtI2WkkailQqS0ZZFjl3QJFZ7CqWDCryIfdvF9lbpiuxitmeAYbbilhqA 9wSWVarRy1hZBpTdrwnmwdDpJUWU7ScZ9H+0Q1171DtGpNQTLcUb4EfjPk35BLRsoxkuHf+SjQF h6VN31m43UIzHdIKCtYInLMQolXK/AHui+hwDm+HpKAqiqny/9Vb1CD5Ff4MqinEF8z4bpZbCea lOKYSPJoWgPIOpFWwgNfj+/98Vlpp989L4cFFYtyCaSaawOTwZ63rEylsoqn1j74G4k3IIKrrZR TkEzQ== X-Received: by 2002:a17:902:ced0:b0:2ba:67f7:9326 with SMTP id d9443c01a7336-2bd2f6080a2mr54506925ad.9.1778716918700; Wed, 13 May 2026 17:01:58 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([203.194.102.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5f30bsm4497835ad.16.2026.05.13.17.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 17:01:58 -0700 (PDT) From: Moksh Panicker To: linux-media@vger.kernel.org Cc: Moksh Panicker , stable@vger.kernel.org Subject: [PATCH] media: mxl111sf: fix null pointer dereference in mxl111sf_ctrl_msg Date: Thu, 14 May 2026 00:01:51 +0000 Message-Id: <20260514000151.9776-1-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When mxl111sf_ctrl_msg() is called during early probe, state->d may not yet be initialized, causing a null pointer dereference in dvb_usbv2_generic_write() when it accesses d->usb_mutex. Add a null check for d before proceeding with the USB transfer. Fixes: d90b336f3f65 ("[media] mxl111sf: Fix driver to use heap allocate buffers for USB messages") Cc: stable@vger.kernel.org Signed-off-by: Moksh Panicker --- drivers/media/usb/dvb-usb-v2/mxl111sf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c index 870ac3c8b085..9908675c355e 100644 --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c @@ -56,6 +56,9 @@ int mxl111sf_ctrl_msg(struct mxl111sf_state *state, int wo = (rbuf == NULL || rlen == 0); /* write-only */ int ret; + if (!d) + return -ENODEV; + if (1 + wlen > MXL_MAX_XFER_SIZE) { pr_warn("%s: len=%d is too big!\n", __func__, wlen); return -EOPNOTSUPP; -- 2.34.1