From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EDC282F35 for ; Thu, 14 May 2026 04:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778732058; cv=none; b=NqA7p0uToZLzATrV5K53bW4Cgn4IcAGflTPsdB/i5fPzP//0CjWmxEAB31TKc0cNQ1zVYooDN/F25e4J42lybChcdmuVHVlpWnqTt8KuEwYkuxx1FGeZj1Ac0XdHplRPgplzQVfIIdpcH3oJLIA17TBML1eC0SXm4L5gOn3329I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778732058; c=relaxed/simple; bh=2/vOX7ppfdtb3zpKHnh7A68Jc+xf7VvYhz53dM5Kq1s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IRuE8ZQ8C5OwxFwCl3rDViHM/GEeakrgX7bjQrsep5HrmXNPn8BTxGKZq2/jcSh/1gTqlD+EDJI5aGbxFeknr9DZg9zXobwh5H5rp+JVSIt2mynI6OaG6KWIFlJK7QP2tFlwsJMbNgBRI0DyNt6T3hD3SClod3CHYsrJBxXzlPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zez4Lonr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zez4Lonr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28853C2BCB7; Thu, 14 May 2026 04:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778732057; bh=2/vOX7ppfdtb3zpKHnh7A68Jc+xf7VvYhz53dM5Kq1s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zez4LonrbOIeeCNsh9o+v9ZStXv50zZ3ckhy8ddmQBZyoxbEV+4tG3D5+3yL8ubc8 LsXRhsqGf60wcG9bnSmHhR0d+MJoesQM6YxI7I2aqs48xL4/plaNIjeLWE/q9VMSRP uq6lSAcLfxlbMFnfdncsdkAd3ouRXDUYvcS2Uq4RJ+T9PdLpK8ooG4Gp2g4Vl3cNC+ sZUyGg8rJY/ldu/58Qzq/HVAQBw1EMbH5KPmjPW+LwrSiYuIR3L46xq3Ss7++laTL7 /63M/BIDY8IBQ/CpnFIZcZfWy2NTG+GE2Kzv1QxnFABhXxq4HumkF7inQBX+3blLIR EeqrbvAiXioAw== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Jingoo Han , Mark Brown , Sasha Levin Subject: [PATCH 6.12.y] spi: tegra114: fix controller deregistration Date: Thu, 14 May 2026 00:14:15 -0400 Message-ID: <20260514041415.4189700-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051237-constable-blinked-f3b7@gregkh> References: <2026051237-constable-blinked-f3b7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit 9c9c27ff2058142d8f800de3186d6864184958de ] Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: 5c8096439600 ("spi: tegra114: use devm_spi_register_master()") Cc: stable@vger.kernel.org # 3.13 Cc: Jingoo Han Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-22-johan@kernel.org Signed-off-by: Mark Brown [ kept `host->dev.of_node = pdev->dev.of_node;` context line above the `spi_register_controller()` conversion ] Signed-off-by: Sasha Levin --- drivers/spi/spi-tegra114.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index 6aed6429358a2..5b8bd34e6bfd9 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -1416,7 +1416,7 @@ static int tegra_spi_probe(struct platform_device *pdev) } host->dev.of_node = pdev->dev.of_node; - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret < 0) { dev_err(&pdev->dev, "can not register to host err %d\n", ret); goto exit_free_irq; @@ -1442,6 +1442,10 @@ static void tegra_spi_remove(struct platform_device *pdev) struct spi_controller *host = platform_get_drvdata(pdev); struct tegra_spi_data *tspi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + free_irq(tspi->irq, tspi); if (tspi->tx_dma_chan) @@ -1453,6 +1457,8 @@ static void tegra_spi_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) tegra_spi_runtime_suspend(&pdev->dev); + + spi_controller_put(host); } #ifdef CONFIG_PM_SLEEP -- 2.53.0