From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 926F42066DE for ; Thu, 14 May 2026 15:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773954; cv=none; b=rA3MZTbfRLJmNOtE9wfcM9tj2fGO71IaXXoFTyaBFG42t6IoSDB0fxikH8TfuHMPgqSQk9Kc7iXUchAfgSurjG28vhnyFBxLlU44Ia4kBBY4JjqGOF5O8m/pZW7esKI97oLgfw4KNIGl4b+ZN9jlwtJnVo+0rbGEshNinq2ze3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773954; c=relaxed/simple; bh=xGHDO7oSzCV5n8CqQc0Zvrs8ifFH38bfjHyN5eM8UAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JipCowtNk2bYh/4qEBzi4JX3WdmBsRFyIRM58Hr1BkiXr3hooCK6IATmCbevsy2RPfcXgQQK19/oi2AG16I7wo36ZuAPSUQ0N3BAAyNC45aoCj6EFuh55PhGbP7WngFXn1HjEEsGzUJ8IHmd5JmvR7nxaa4503pwyhJBWWYQ37Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R7PKVHYF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R7PKVHYF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1E5CC2BCB3; Thu, 14 May 2026 15:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778773954; bh=xGHDO7oSzCV5n8CqQc0Zvrs8ifFH38bfjHyN5eM8UAM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R7PKVHYF6LIByJMeSTH7C8gzsua5mdBGmqzIt26k72Hx1ng1GJ3SqAEkhe09wkOOB mdjHqKRnPYhGkccIBuUXEhLOguHF8PiCEqQRZ2OKm2hR3n7sDr0dE63gHN6+MyMle6 oe/vrlo+P0HDXM8j1yY8CPdXuWcyq4u3kq5WIiKGMm855YzqQTl2bETVyKyUF0Ipc1 WbMvrB4RKm2uQ86qlNeLg4sXGzqfKBAg55u6ILW25DU1r518DRBrDTvJSkRtZxVEYX Nfq3QhEnhGAIiDKfsq/oDW3gQ6okYjkpWcsNXzI4kikLM2Lmjpo7zILPJ+I3u/sC3H MOqEzgJmdzgYQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Prasanna Kumar T S M , "Borislav Petkov (AMD)" , Sasha Levin Subject: [PATCH 6.18.y] EDAC/versalnet: Fix device name memory leak Date: Thu, 14 May 2026 11:52:31 -0400 Message-ID: <20260514155232.307214-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051203-jasmine-payment-6259@gregkh> References: <2026051203-jasmine-payment-6259@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Prasanna Kumar T S M [ Upstream commit 8cf5dd235eff6008cb04c3d8064d2acfa90616f1 ] The device name allocated via kzalloc() in init_one_mc() is assigned to dev->init_name but never freed on the normal removal path. device_register() copies init_name and then sets dev->init_name to NULL, so the name pointer becomes unreachable from the device. Thus leaking memory. Use a stack-local char array instead of using kzalloc() for name. Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller") Signed-off-by: Prasanna Kumar T S M Signed-off-by: Borislav Petkov (AMD) Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260401111856.2342975-1-ptsm@linux.microsoft.com [ adapted fix from `init_one_mc()` helper to the equivalent loop in `init_versalnet()` using literal `32` instead of `MC_NAME_LEN` ] Signed-off-by: Sasha Levin --- drivers/edac/versalnet_edac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index f90723bc93d5c..4053ee2e0beef 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -765,9 +765,9 @@ static int init_versalnet(struct mc_priv *priv, struct platform_device *pdev) u32 num_chans, rank, dwidth, config; struct edac_mc_layer layers[2]; struct mem_ctl_info *mci; + char name[32]; struct device *dev; enum dev_type dt; - char *name; int rc, i; for (i = 0; i < NUM_CONTROLLERS; i++) { @@ -814,7 +814,6 @@ static int init_versalnet(struct mc_priv *priv, struct platform_device *pdev) dev = kzalloc(sizeof(*dev), GFP_KERNEL); dev->release = versal_edac_release; - name = kmalloc(32, GFP_KERNEL); sprintf(name, "versal-net-ddrmc5-edac-%d", i); dev->init_name = name; rc = device_register(dev); -- 2.53.0