From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90EB63F4132 for ; Fri, 15 May 2026 05:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778823191; cv=none; b=rCB8gNK2cBCGL1FxbEgSMtW1GLpAijib/Ejyh71RwArgGUHQP4y7jK+cvTmnUoZtsaHQbOSaJS1YWIhlRQ8RfNLZb/ydC/A0di+NdwrQFd9RHqzT+uAIar0Ovcb7q1HqfDaBjEmqeAAezpJvvAB9Y4BIna1F8jTTlSPAsHqSkFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778823191; c=relaxed/simple; bh=7j8Mn7y6aB/p/rlZWOUkUgDT6dqIQyvObxwxovXQuWw=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=BFfWafmDn0tBDJ4Ri1iPYAApc2iZ+j8M/XqOpZPUVLdRz6eN+G8n9blIM2p/0Y8tsj4nm6rRjyNjQxsNXZ51y2ybNhnxhDEafkYWRAdHBoRpdKXm/VIAd+qp4MeC6SmTqHys7bMzqfG8nDcIhahPsG53IT3ZzTXEtSHFq6V/v+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=otkFlnbi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="otkFlnbi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DE7AC2BCB0; Fri, 15 May 2026 05:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778823191; bh=7j8Mn7y6aB/p/rlZWOUkUgDT6dqIQyvObxwxovXQuWw=; h=Subject:To:Cc:From:Date:From; b=otkFlnbieC62o3LezTT+Kfx40jZ9TBYSrsuvDFNpykv7WsmDejmXfmf22UVNSfZJx LBuIQBW9uuKIemaWrvPt0j7PR931Jlbz6azWHDVgcTXUyrcDtnJ7XJOGhB1SbqLAuS dYxqYwvloyBHxZm6K6w9tX+UjCiQebWChnd9v2JE= Subject: FAILED: patch "[PATCH] spi: aspeed-smc: fix controller deregistration" failed to apply to 5.10-stable tree To: johan@kernel.org,broonie@kernel.org,clg@kaod.org Cc: From: Date: Fri, 15 May 2026 07:33:05 +0200 Message-ID: <2026051505-curdle-uptake-151a@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 1044e5a4ccd57bf5a64f90100a321b498e0267a2 # git commit -s git send-email --to '' --in-reply-to '2026051505-curdle-uptake-151a@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 1044e5a4ccd57bf5a64f90100a321b498e0267a2 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Thu, 9 Apr 2026 14:04:01 +0200 Subject: [PATCH] spi: aspeed-smc: fix controller deregistration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before disabling it to allow SPI device drivers to do I/O during deregistration. Fixes: e3228ed92893 ("spi: spi-mem: Convert Aspeed SMC driver to spi-mem") Cc: stable@vger.kernel.org # 5.19 Cc: Cédric Le Goater Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260409120419.388546-3-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c index 9c286e534bf0..c21323e07d3c 100644 --- a/drivers/spi/spi-aspeed-smc.c +++ b/drivers/spi/spi-aspeed-smc.c @@ -972,7 +972,7 @@ static int aspeed_spi_probe(struct platform_device *pdev) return -ENOMEM; aspi = spi_controller_get_devdata(ctlr); - platform_set_drvdata(pdev, aspi); + platform_set_drvdata(pdev, ctlr); aspi->data = data; aspi->dev = dev; @@ -1021,7 +1021,7 @@ static int aspeed_spi_probe(struct platform_device *pdev) return ret; } - ret = devm_spi_register_controller(dev, ctlr); + ret = spi_register_controller(ctlr); if (ret) dev_err(&pdev->dev, "spi_register_controller failed\n"); @@ -1030,7 +1030,10 @@ static int aspeed_spi_probe(struct platform_device *pdev) static void aspeed_spi_remove(struct platform_device *pdev) { - struct aspeed_spi *aspi = platform_get_drvdata(pdev); + struct spi_controller *ctlr = platform_get_drvdata(pdev); + struct aspeed_spi *aspi = spi_controller_get_devdata(ctlr); + + spi_unregister_controller(ctlr); aspeed_spi_enable(aspi, false); }