From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B387147DF8D for ; Fri, 15 May 2026 11:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778846175; cv=none; b=P29iU/hoGPYQvmk/K6Dsx9pNMlYECVNaf3S7g+TaE9cv7mlHQZkEXTHv5GUjcSawj1hF0flkKVwUqf6JSFvb0ae1GWLJPRY/XMo0g61FpYeYULtZZaQc4JB4sW1AE8WZ5XJNLRV4OwgD+KiI3odJv4QduqaCIqWk738iEIJloLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778846175; c=relaxed/simple; bh=NF4c2ISjBxqtyKJlDqof4Ax6aWPtRpcHf88u6qP0jZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SeqEjqLHJKjYc3jMbEhjHqP8RxjGbbeeWeu3pZzPxFTkfB8sEp7orFi9s3P5avgQLon5MCxEfxk14zPg6g8f6lMeO/mYW8rjNS+ap1Dot3Ml4eJaeIV40sWZX7lDs8UkN8k4dMh3MgUQ4roamrb8M2lQYEx+HKI/errScy0Mb8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=klbLocm4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="klbLocm4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF436C2BCB0; Fri, 15 May 2026 11:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778846175; bh=NF4c2ISjBxqtyKJlDqof4Ax6aWPtRpcHf88u6qP0jZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=klbLocm4GqsxEDst7ynsZ/2pXHuxrBnfl2RO+WxxdiK7FVIjhDBLFlSJu42QvnyjX GehrtSjWM9onm0o8jAV0xNMrMgR4g76OImRGABQbFrOLZpDjQLqIo8rlOLi79nCaYD lHh1suLG7AEIVcC6Zdku3whhK44OZGWuAKIVtGrAt5zTSK551PwKV8dgzbT7ekCseN ojmxwrhsW8y0DwQQHP9KUyRZFaZhEVt3QsND/YvzR6F9a/HOMQ4lb8i1qW8m3wTPDe eE3jPZAhoq2aE+QBh1GZbOnvGrhK4BrlFEd3aHjEUKCSTLp5yrMxzplT1MvN/I1CxJ GuIJGYwvLMKVQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Thomas Zimmermann , Helge Deller , Sasha Levin Subject: [PATCH 5.10.y] fbcon: Avoid OOB font access if console rotation fails Date: Fri, 15 May 2026 07:56:13 -0400 Message-ID: <20260515115613.3041015-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051242-unused-clone-b894@gregkh> References: <2026051242-unused-clone-b894@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thomas Zimmermann [ Upstream commit e4ef723d8975a2694cc90733a6b888a5e2841842 ] Clear the font buffer if the reallocation during console rotation fails in fbcon_rotate_font(). The putcs implementations for the rotated buffer will return early in this case. See [1] for an example. Currently, fbcon_rotate_font() keeps the old buffer, which is too small for the rotated font. Printing to the rotated console with a high-enough character code will overflow the font buffer. v2: - fix typos in commit message Signed-off-by: Thomas Zimmermann Fixes: 6cc50e1c5b57 ("[PATCH] fbcon: Console Rotation - Add support to rotate font bitmap") Cc: stable@vger.kernel.org # v2.6.15+ Link: https://elixir.bootlin.com/linux/v6.19/source/drivers/video/fbdev/core/fbcon_ccw.c#L144 # [1] Signed-off-by: Helge Deller [ renamed `par` to `ops` to match the 6.12 local pointer name ] Signed-off-by: Sasha Levin --- drivers/video/fbdev/core/fbcon_rotate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/core/fbcon_rotate.c index ef1d421c261a8..c1beb4a837081 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.c +++ b/drivers/video/fbdev/core/fbcon_rotate.c @@ -46,6 +46,10 @@ static int fbcon_rotate_font(struct fb_info *info, struct vc_data *vc) info->fbops->fb_sync(info); if (ops->fd_size < d_cellsize * len) { + kfree(ops->fontbuffer); + ops->fontbuffer = NULL; + ops->fd_size = 0; + dst = kmalloc_array(len, d_cellsize, GFP_KERNEL); if (dst == NULL) { @@ -54,7 +58,6 @@ static int fbcon_rotate_font(struct fb_info *info, struct vc_data *vc) } ops->fd_size = d_cellsize * len; - kfree(ops->fontbuffer); ops->fontbuffer = dst; } -- 2.53.0