From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463593FE647 for ; Fri, 15 May 2026 08:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833720; cv=none; b=a5dPk3ISuncrpDGGNuipnGuBFKlZUTkC4SZ/57dtA8Na1BhDXzKEzA/sow8ORsF2ThDpAE9kM70vFGW9HjDS7+E3u1dFrXV9fLkqBj9Wjdg4kRqZbHOFdVHDiVkY5FDEYhvJI4JW/IKCNdx30iz5uqwtdBNCsHD85ZgJFE+HOA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833720; c=relaxed/simple; bh=c7UsI6k9sWPoRd3DNOmP+kB/ucYJoJGl7z7f1eNizeg=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=PiNi3p6sNZOX4KrojxJHTlyDM09YgmVcfXBbMhZjIHlrLLUOqkM56+d6FWVwMXBzx1JrHGoprKyBVTqMs9bioT3LH3e8iqnZ7Qpoa/0PingU1r444ScjSjOzlmQH5ybKQVGCWEWTML0pxsdEYejPMReJqMhVkaDXgLrh5vfqnXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=b1AxKd8T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="b1AxKd8T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 881CDC2BCB0; Fri, 15 May 2026 08:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778833719; bh=c7UsI6k9sWPoRd3DNOmP+kB/ucYJoJGl7z7f1eNizeg=; h=Subject:To:Cc:From:Date:From; b=b1AxKd8T6oSJo2+lQAnklzQVJYH/cAUAlB7Pa4JOo+juHoUceIKn4ghEEjKDVMDiW OepeVialsO2YpbhmEoobWuyJScxAtrNFuZF48Ojw7L5350keueyLoqmrKx4TAHiv9Q 1SWv/H4uv62K2SUh7rP7DdqISxc8Vlo2z2ZOm4AE= Subject: FAILED: patch "[PATCH] spi: fsl: fix controller deregistration" failed to apply to 5.10-stable tree To: johan@kernel.org,broonie@kernel.org,hkallweit1@gmail.com Cc: From: Date: Fri, 15 May 2026 10:28:12 +0200 Message-ID: <2026051512-enslave-cilantro-de45@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 9b7abfed4c3754062d1f3ffd452e65a38667f586 # git commit -s git send-email --to '' --in-reply-to '2026051512-enslave-cilantro-de45@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 9b7abfed4c3754062d1f3ffd452e65a38667f586 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 10 Apr 2026 08:47:49 +0200 Subject: [PATCH] spi: fsl: fix controller deregistration Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 4178b6b1b595 ("spi: fsl-(e)spi: migrate to using devm_ functions to simplify cleanup") Cc: stable@vger.kernel.org # 4.3 Cc: Heiner Kallweit Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410064749.496888-1-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index bf3fc3ce0cc2..1252c41c206f 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -614,7 +614,7 @@ static struct spi_controller *fsl_spi_probe(struct device *dev, mpc8xxx_spi_write_reg(®_base->mode, regval); - ret = devm_spi_register_controller(dev, host); + ret = spi_register_controller(host); if (ret < 0) goto err_probe; @@ -705,7 +705,13 @@ static void of_fsl_spi_remove(struct platform_device *ofdev) struct spi_controller *host = platform_get_drvdata(ofdev); struct mpc8xxx_spi *mpc8xxx_spi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + fsl_spi_cpm_free(mpc8xxx_spi); + + spi_controller_put(host); } static struct platform_driver of_fsl_spi_driver = { @@ -751,7 +757,13 @@ static void plat_mpc8xxx_spi_remove(struct platform_device *pdev) struct spi_controller *host = platform_get_drvdata(pdev); struct mpc8xxx_spi *mpc8xxx_spi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + fsl_spi_cpm_free(mpc8xxx_spi); + + spi_controller_put(host); } MODULE_ALIAS("platform:mpc8xxx_spi");