From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 366D73FF1A2; Fri, 15 May 2026 15:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778860237; cv=none; b=tcLrQrkmFhWPuPYNM4hqJAAPTyAkGny/m6Od90PG4OVAnkbK4lDiUGe6cMiWIWLHMfVkmmB2fCMQjykjjGBaXX7CcZx0HjGwBBwVWs0LJa069rj+yt4fWR+Brz+ZAHu/oSLNU0mHWBaP9wJbO3LQjd+8kbMlMo37WRacxIplyj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778860237; c=relaxed/simple; bh=BkihdvWBqzw7uRs99Zmc5TIDX6xSFf+ECuaU4RAfAhY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=heY/P2EwsPkHlMo2vYO30AcLSqc/t99rCcVLdd4+uL6J88yubIhJsDxsZIqe6ZFu68kGVyJyEfHZwmgJSkr/yOQNbO2gPqTrMHUD9fHHO0OxMwNa7V+Pvlbjd1jarC+kFN/ZAQpL9TczCO8fzjz6iD3ljXONrDIjO0kTEtvWiTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PdMHRXxb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PdMHRXxb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D2F4C2BCB0; Fri, 15 May 2026 15:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778860236; bh=BkihdvWBqzw7uRs99Zmc5TIDX6xSFf+ECuaU4RAfAhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PdMHRXxbo1wTG9FLRZbGrJ/a7PYtuuGIOTrnha9ScYwih5CizUGGnie3KZSp6NeW8 3SxJdvcQUYkoss4U1c6QbM6dicCGT9+zazCZxDK1J3LETISrbvBiGaEsF8h8lO0vdT NivMnWt3dJ3Q2LFF7rgzO4PLaLEMrZpvrllueKLc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Mark Brown Subject: [PATCH 6.12 012/144] regulator: mt6357: fix OF node reference imbalance Date: Fri, 15 May 2026 17:47:18 +0200 Message-ID: <20260515154653.774454007@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154653.469907118@linuxfoundation.org> References: <20260515154653.469907118@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 2f38e96c273e15f5e9f5d1fc2c0cbba703751602 upstream. The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: dafc7cde23dc ("regulator: add mt6357 regulator") Cc: stable@vger.kernel.org # 6.2 Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260408073055.5183-5-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/regulator/mt6357-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/regulator/mt6357-regulator.c +++ b/drivers/regulator/mt6357-regulator.c @@ -410,7 +410,7 @@ static int mt6357_regulator_probe(struct struct regulator_dev *rdev; int i; - pdev->dev.of_node = pdev->dev.parent->of_node; + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); for (i = 0; i < MT6357_MAX_REGULATOR; i++) { config.dev = &pdev->dev;