From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93E130567C; Fri, 15 May 2026 16:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861923; cv=none; b=ALP/r1omiaOVqTJJ05hI9H3tgeVdDM+eeECT9gR0K5Du89CVCcAEK1Ej7bYn1HZ05h72hZfLX0X5WdOS5hVEGYSQLv+IO+A2SkWrEgj/+t+f0XIEK87sDXBmDU9VErplhE59VEQARefir4t1+Km/KOpK6N5eholFNcX29BEgZEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861923; c=relaxed/simple; bh=E25cKmsMyoyo2SdLVFmF05NDZeh2DTmXBfUGPqpJzoY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QREECWlo8hBN5PqSdbUxC1PbeQXvku6N3VLa1rp6nHE1xwLP52bsfPpA8zZCTOJqzvUAYcpgXpgLAY+DXuxSMYpGTKgex3WOPG8qbE29FX201rxKFuWnKFJFBtaBfnGG1xKTcUc0ajjXvuXpEW6DPIk3OXR/kv3jSwy7XjJthfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cp5DCC/0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cp5DCC/0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63A1CC2BCB0; Fri, 15 May 2026 16:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861923; bh=E25cKmsMyoyo2SdLVFmF05NDZeh2DTmXBfUGPqpJzoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cp5DCC/0DLkza9VhwbocDjaWVv7EcCiIBU/ltLntlJT/RVWNKUJ4jjlHEUxBkikcl D/ieZ7SERs79rvllIjL8yY+jS/IIcYkMAclLvI1+bGXrTt+jfy8lJmKbEXdEPsD7Lv b/4TQWyaX4br92VZD5DPhK7Fgr9/VBYM6x+s2aIk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Radu Pirea , Johan Hovold , Mark Brown Subject: [PATCH 6.18 040/188] spi: at91-usart: fix controller deregistration Date: Fri, 15 May 2026 17:47:37 +0200 Message-ID: <20260515154658.181055362@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154657.309489048@linuxfoundation.org> References: <20260515154657.309489048@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 9acecc9bcff058eaef40fd7a4c3650e88b06b220 upstream. Make sure to deregister the controller before disabling and releasing underlying resources like clocks and DMA during driver unbind. Fixes: e1892546ff66 ("spi: at91-usart: Add driver for at91-usart as SPI") Cc: stable@vger.kernel.org # 4.20 Cc: Radu Pirea Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260409120419.388546-4-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-at91-usart.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -556,7 +556,7 @@ static int at91_usart_spi_probe(struct p spin_lock_init(&aus->lock); init_completion(&aus->xfer_completion); - ret = devm_spi_register_controller(&pdev->dev, controller); + ret = spi_register_controller(controller); if (ret) goto at91_usart_fail_register_controller; @@ -634,8 +634,14 @@ static void at91_usart_spi_remove(struct struct spi_controller *ctlr = platform_get_drvdata(pdev); struct at91_usart_spi *aus = spi_controller_get_devdata(ctlr); + spi_controller_get(ctlr); + + spi_unregister_controller(ctlr); + at91_usart_spi_release_dma(ctlr); clk_disable_unprepare(aus->clk); + + spi_controller_put(ctlr); } static const struct dev_pm_ops at91_usart_spi_pm_ops = {