From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B5F39734B; Fri, 15 May 2026 16:29:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778862557; cv=none; b=ozhxeNj61Oaz/GN5CCeEfYQiQs9K5axh7h4sLU+YVp0Y/hIFjm9ATg7Wx4FYI1wjU2hiJoZgj7AfX0vLFMDH+TpiJwBJAXO5pxJ17LfmwFOkPHjeA/Qqs4u54A1+ZQ/Z4N0qOPtr48oNUx6iZpl7q+15IhSWeAAST9dSiAAxF5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778862557; c=relaxed/simple; bh=rVD1qtAXyT+qsuJSghL6ozGGZqYVpPnq5uSSy6lZUsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hCkJzOgpCYt/ywiNjLA7p/ZnKc1uzmTPaMyf4ZoGhmo+8ks97lpimi4IMGrubKtHnxLJMGIrdI/RzzBh7V3nLGbjjnS10go3uk/JF4ZPDdCsTpOWe89eo9w8BTmQYbck56anp2HX+KT9wW6dVUTfjdz0FK/7FJsndnOr8NMsJFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z3+Y26W1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z3+Y26W1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BE0AC2BCB0; Fri, 15 May 2026 16:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778862557; bh=rVD1qtAXyT+qsuJSghL6ozGGZqYVpPnq5uSSy6lZUsg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z3+Y26W1vkqIfRef6JePkEFcSrQCb2uRODzUaOxBIc39XUvbi8I0Vc+nWWRnAaSID WHPYlZ7xIqBIy8sRIi5ghpyc638afQKpH8FH9dqRfNl0DDUqeAtEXEtEenbprBBKPS R6dip/KDAU3RGoJqyTHBqpwzfqzSLMeHD82zzY3s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiner Kallweit , Johan Hovold , Mark Brown Subject: [PATCH 7.0 095/201] spi: fsl: fix controller deregistration Date: Fri, 15 May 2026 17:48:33 +0200 Message-ID: <20260515154700.591256361@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154658.538039039@linuxfoundation.org> References: <20260515154658.538039039@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 9b7abfed4c3754062d1f3ffd452e65a38667f586 upstream. Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 4178b6b1b595 ("spi: fsl-(e)spi: migrate to using devm_ functions to simplify cleanup") Cc: stable@vger.kernel.org # 4.3 Cc: Heiner Kallweit Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410064749.496888-1-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-fsl-spi.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -614,7 +614,7 @@ static struct spi_controller *fsl_spi_pr mpc8xxx_spi_write_reg(®_base->mode, regval); - ret = devm_spi_register_controller(dev, host); + ret = spi_register_controller(host); if (ret < 0) goto err_probe; @@ -705,7 +705,13 @@ static void of_fsl_spi_remove(struct pla struct spi_controller *host = platform_get_drvdata(ofdev); struct mpc8xxx_spi *mpc8xxx_spi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + fsl_spi_cpm_free(mpc8xxx_spi); + + spi_controller_put(host); } static struct platform_driver of_fsl_spi_driver = { @@ -751,7 +757,13 @@ static void plat_mpc8xxx_spi_remove(stru struct spi_controller *host = platform_get_drvdata(pdev); struct mpc8xxx_spi *mpc8xxx_spi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + fsl_spi_cpm_free(mpc8xxx_spi); + + spi_controller_put(host); } MODULE_ALIAS("platform:mpc8xxx_spi");