From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61D0318EE4; Fri, 15 May 2026 16:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778860815; cv=none; b=lXod0Ozr/bXT2/BDzudpzqtLEMe17LmV3NbIP+Rc/ETgG0tJOu+aDeLDkd54IxI9BanrElHzk7lPQJyOr27HiClblVlff9M4RKGWeZRSr5zBgMaOqgXrpECio2gvXOF3nkwuisWo90DSKplmDW0Kox0neme8pUJi32bG2vGSptE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778860815; c=relaxed/simple; bh=KxLCrtReEn3qj3y0d50EEoKtV9dEgSf6ZcbNHiokjS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PBPkVszjF/UuYzWgr0ic1m/+QkkZkz4bHMElQdAzTY0NhgsY+jTPtDxu6xyD7gXRosOL3hX9fXHenlvx4uuP9bZylGr1/qHeclnGa/ITLX8hgCNsdhUsvWKqeR7Z599QYegcmQlPRMQPY0edID1ri3tVfsrd0l6UKd99PePmgrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YSh2plax; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YSh2plax" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C367C2BCB3; Fri, 15 May 2026 16:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778860815; bh=KxLCrtReEn3qj3y0d50EEoKtV9dEgSf6ZcbNHiokjS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YSh2plaxUNQJZ5qVyYznxt3hrZ/9k0RqFHfn2ppAjFymDTHTx/VFNVwWs57Jglsqb CxyPf8i9v9mvTuGQDhNd925fxshINP/ooPIeYUTtpo5aWNpsWj12Xu60Qpcble8dni 3fa2zy9eEfeSEh1PiSgBKKgyagYRfiEowKHgutv0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jacqueline Wong , Jordan Hand , Jarkko Sakkinen Subject: [PATCH 6.6 089/474] tpm: tpm_tis: add error logging for data transfer Date: Fri, 15 May 2026 17:43:18 +0200 Message-ID: <20260515154716.963435110@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jacqueline Wong commit 0471921e2d1043dcc6de5cffb49dd37709521abe upstream. Add logging to more easily determine reason for transmit failure Cc: stable@vger.kernel.org # v6.6+ Fixes: 280db21e153d8 ("tpm_tis: Resend command to recover from data transfer errors") Signed-off-by: Jacqueline Wong Signed-off-by: Jordan Hand Link: https://lore.kernel.org/r/20260415160006.2275325-2-jacqwong@google.com Signed-off-by: Jarkko Sakkinen Signed-off-by: Greg Kroah-Hartman --- drivers/char/tpm/tpm_tis_core.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -472,6 +472,8 @@ static int tpm_tis_send_data(struct tpm_ status = tpm_tis_status(chip); if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) { rc = -EIO; + dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be set. sts = 0x%08x\n", + status); goto out_err; } } @@ -492,6 +494,8 @@ static int tpm_tis_send_data(struct tpm_ status = tpm_tis_status(chip); if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) { rc = -EIO; + dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be unset. sts = 0x%08x\n", + status); goto out_err; }