From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11BA3F44C0; Fri, 15 May 2026 16:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861311; cv=none; b=ZqZJsAEF+BHuKoPtHijiSlY5Z58uBLV2MRpP34H8W2EZkMOFg/mdzExnCKEnk0HHkq1PHX1mKIS60iaMIbb5WE02lhORKvTKdrFOCY7W/4Jh0t5H3NyeMY9Bv/ayxYjpHMtsOPWLwt6TEX+t7KY78WrFw2hSSpJc509NoVO8a+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861311; c=relaxed/simple; bh=45vyBPKZxggtCmMWYEA/PNsAjkwSkWHoJVao+4knltA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cX6zgYTrBj1lQ5EAU7syRzOEAejEk4COaJa9KM1cLUo4t9SicAqBsj+Cl/Ega3K6qsoctSZAOq9G5xfIRIQ8z0+RSKxqNwOB9QLHBwRXWvWvroVUkeUeooI0sl5frTFzSlHeh1GKZxhJmKft/Z6pWZOSwDv8OrhrNi9qySixAv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qREgLPsL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qREgLPsL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 635FAC2BCB0; Fri, 15 May 2026 16:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861311; bh=45vyBPKZxggtCmMWYEA/PNsAjkwSkWHoJVao+4knltA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qREgLPsLCksXlg1VuKHLG1xDCAqRuv7z1F/v/5qKLeVo+EBwJ7YX/6sBGUhmxdMJV CwGVso2wuzNAqn11xI1EFkUz01jQucoXvR9zn4EpASwZoGYWv+D4AYhgyhETfnBGc2 3aZmaTYmABdeti+OMpkvw5fC4xlF+WMF/knx/7HA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jason Gunthorpe Subject: [PATCH 6.6 279/474] RDMA/ocrdma: Dont NULL deref uctx on errors in ocrdma_copy_pd_uresp() Date: Fri, 15 May 2026 17:46:28 +0200 Message-ID: <20260515154721.037580834@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jason Gunthorpe commit 34fbf48cf3b410d2a6e8c586fa952a36331ca5ba upstream. Sashiko points out that pd->uctx isn't initialized until late in the function so all these error flow references are NULL and will crash. Use the uctx that isn't NULL. Cc: stable@vger.kernel.org Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter") Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4 Link: https://patch.msgid.link/r/9-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -620,9 +620,9 @@ static int ocrdma_copy_pd_uresp(struct o ucopy_err: if (pd->dpp_enabled) - ocrdma_del_mmap(pd->uctx, dpp_page_addr, PAGE_SIZE); + ocrdma_del_mmap(uctx, dpp_page_addr, PAGE_SIZE); dpp_map_err: - ocrdma_del_mmap(pd->uctx, db_page_addr, db_page_size); + ocrdma_del_mmap(uctx, db_page_addr, db_page_size); return status; }