From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD143F86E1; Fri, 15 May 2026 16:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861387; cv=none; b=kVZbwfO9RggmChM6eEmUARLvFdrJJj4I31yYFQeYwWaOqw92Pw+sAKPqMO09YivDABjX0J3LgQSzSUpjQSikhdSGbKMtJvNCXh22jtNo/+EFLzQrEWk+xDgoWO2kRohlRkcWS+Qb64jgTIx8XjgFT1RWc+ukzbc87XV8f8ojTlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861387; c=relaxed/simple; bh=Wjyj/ze//pucDjZ4XBl0MUYJMrJFek5Gji513WjfnwA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m9DG4RrSWejE8BEfi6crN8AeVabgwtRDPkX2OQELx4DfVXDYIRIwGMmhT+fTXF0UEbaEvz2u8wwwH6M1zbJsh3YINucWZ9fHgebtV/Hsow5KHzN3pVrO/wXWQO24hh5q5WJqWn4sOMjq5wAllpaaYkQmJFNm9mCYfZm9xj7e05c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=w2jROBE7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="w2jROBE7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81429C2BCB0; Fri, 15 May 2026 16:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861386; bh=Wjyj/ze//pucDjZ4XBl0MUYJMrJFek5Gji513WjfnwA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w2jROBE7QgIgCxHfVKtzjqoUyemV39JHLEcaDB9oJsr5Zj/qZxBe02B+1QOH8hspm IelFqXao4an9G3brKp855PF3bwT9ePJwurJvMsvicGgI5OPCqe+Szp2og6vT0OSWNN ch4J9+QBF2u7oLFycghxL3Kbg6FxBDpE3eYWA+pQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wenyou Yang , Johan Hovold , Mark Brown Subject: [PATCH 6.6 309/474] regulator: act8945a: fix OF node reference imbalance Date: Fri, 15 May 2026 17:46:58 +0200 Message-ID: <20260515154721.693006354@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 0d15ce31375ccef4162f960b34547a821b7619d2 upstream. The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: 38c09961048b ("regulator: act8945a: add regulator driver for ACT8945A") Cc: stable@vger.kernel.org # 4.6 Cc: Wenyou Yang Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260408073055.5183-7-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/regulator/act8945a-regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/regulator/act8945a-regulator.c +++ b/drivers/regulator/act8945a-regulator.c @@ -302,8 +302,9 @@ static int act8945a_pmic_probe(struct pl num_regulators = ARRAY_SIZE(act8945a_regulators); } + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + config.dev = &pdev->dev; - config.dev->of_node = pdev->dev.parent->of_node; config.driver_data = act8945a; for (i = 0; i < num_regulators; i++) { rdev = devm_regulator_register(&pdev->dev, ®ulators[i],