From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CF8E3BB116; Fri, 15 May 2026 16:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861407; cv=none; b=abxNTWPQ4qriI4RWyHOHmhWAagls0WSIoW2vLKeAMfmZM6oeJIcJJovnBvtRcfidRvnPwX880sBJktSB6pKdLrerbNZH8DBlHQ+gOvfO03az775lPN5ig3+vtff9aW3tIXB599kYbOVSTBF3jnvu11PMcnvIHeIi55ziAiIGyXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861407; c=relaxed/simple; bh=0X6swvLz0N61vsr53DRZo6onkBijxL9aYHZsGxl3zlI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YnYGSq4lCpeLUtAGVhLeJZIQ/c30PoMUaLRXOnXp0uu9SuInJS/t6GdrDSAecheNSPzKZ9eOMOg6BDfvySY+zO++SFw9LingSu2ZHmODl46Fnfb9y958XZgT/lX/QYc+SOfUTNIy7F+YRZySnGSBYIvTF86z+QW67mOg5DdIoFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=a3BabgUp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="a3BabgUp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5C8C2BCB3; Fri, 15 May 2026 16:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861407; bh=0X6swvLz0N61vsr53DRZo6onkBijxL9aYHZsGxl3zlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a3BabgUprULnqWpkzmH5ZuCKw9xP0BRehkuUtDHlc8CgSDicaJkZyz8MY37zjjKcd Y08N4IrA+7OKk3GyV35fnAp1ogx+cEDamRNGsU3v3g0kuJ702aMcANpU4/RPAR5V5n BE23yxdMq9uVzVD8TZxAvBqumzxGHl9s6KHdGWbU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sergey Shtylyov , Hans Verkuil Subject: [PATCH 6.6 317/474] media: dib8000: avoid division by 0 in dib8000_set_dds() Date: Fri, 15 May 2026 17:47:06 +0200 Message-ID: <20260515154721.871568989@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sergey Shtylyov commit dde3c37af95cd6fa301c4906f33d627bc9dd874c upstream. In dib8000_set_dds(), 1 << 26 (67108864) divided by e.g. 1 apparently can't fit into 16-bit variable unit_khz_dds_val, being truncated to 0; this will cause division by 0 while calling dprintk() with debugging enabled (via the module parameter). Use s32 instead of s16 to declare the variable, getting rid of the cast to u16 in the *else* branch as well... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. Fixes: 173a64cb3fcf ("[media] dib8000: enhancement") Cc: stable@vger.kernel.org Signed-off-by: Sergey Shtylyov Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-frontends/dib8000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/media/dvb-frontends/dib8000.c +++ b/drivers/media/dvb-frontends/dib8000.c @@ -2694,7 +2694,7 @@ static void dib8000_viterbi_state(struct static void dib8000_set_dds(struct dib8000_state *state, s32 offset_khz) { - s16 unit_khz_dds_val; + s32 unit_khz_dds_val; u32 abs_offset_khz = abs(offset_khz); u32 dds = state->cfg.pll->ifreq & 0x1ffffff; u8 invert = !!(state->cfg.pll->ifreq & (1 << 25)); @@ -2715,7 +2715,7 @@ static void dib8000_set_dds(struct dib80 dds = (1<<26) - dds; } else { ratio = 2; - unit_khz_dds_val = (u16) (67108864 / state->cfg.pll->internal); + unit_khz_dds_val = 67108864 / state->cfg.pll->internal; if (offset_khz < 0) unit_khz_dds_val *= -1;