From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90613C4B72; Fri, 15 May 2026 16:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861428; cv=none; b=BN0SHEPjtJfTfvK5fmgwiABYSg7djmXXU1vlJCAuK8wjSDKvUQSCXsfpIZLNtlB3QcO52rroWYMTPZo5muckBb2c8t1sZtL22fmBJZCst3zuTw3GkRwRVlqcTGgLTvk3c/Mga51EzTW+yu3LVuj/OevL9P+2Vtd0+qWyDRyultY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861428; c=relaxed/simple; bh=EgyRXerigE3WyKB+CpSEBcfFqP1TNdDKtS2jT4J/ECk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QT0DSIcik4jfaUnhH7MqmqHHWSPQt1gfNZrfLClIMw8m+ykpygCs+GRYBBtSrERXo0ieU53kdhn+2aaubNBBa8tL5OtNzugQEbn7L1jJi0Rl5LnxP9Zxtq4exJ20t3YyMXVu8zNyascbbsj8FE6k9PBpGffPYtVI2G0RR9KnMBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2df9iKJV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2df9iKJV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D800C2BCB0; Fri, 15 May 2026 16:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861428; bh=EgyRXerigE3WyKB+CpSEBcfFqP1TNdDKtS2jT4J/ECk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2df9iKJVwXJr+hZ3X3/bOZ8YVExJ7JR2zrodkUFhd4ZMPyXz9bykv+nPD7Pnh8QX7 O05MpgUBBkJPnA6Ogilvi6C9/DYnDGYb0OEfHIJC6l0LHGd13xVZA/qtGlgmvvNjP2 0PmlZzh5LbeyASzTYmLjkUXmR7+/YfN7RUWfGg74= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiner Kallweit , Johan Hovold , Mark Brown Subject: [PATCH 6.6 324/474] spi: fsl-espi: fix controller deregistration Date: Fri, 15 May 2026 17:47:13 +0200 Message-ID: <20260515154722.020879154@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit e506a700a7ad229f5c8f01f4b8350119cccb4158 upstream. Make sure to deregister the controller before disabling runtime PM (which can leave the controller disabled) to allow SPI device drivers to do I/O during deregistration. Fixes: e9abb4db8d10 ("spi: fsl-espi: add runtime PM") Cc: stable@vger.kernel.org # 4.3 Cc: Heiner Kallweit Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260409120419.388546-14-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-fsl-espi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -720,7 +720,7 @@ static int fsl_espi_probe(struct device pm_runtime_enable(dev); pm_runtime_get_sync(dev); - ret = devm_spi_register_controller(dev, host); + ret = spi_register_controller(host); if (ret < 0) goto err_pm; @@ -785,7 +785,15 @@ static int of_fsl_espi_probe(struct plat static void of_fsl_espi_remove(struct platform_device *dev) { + struct spi_controller *host = platform_get_drvdata(dev); + + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(&dev->dev); + + spi_controller_put(host); } #ifdef CONFIG_PM_SLEEP