Re: [PATCH 6.6.y 2/2] spi: topcliff-pch: fix controller deregistration

[Greg KH <greg@kroah.com>]

On Fri, May 15, 2026 at 07:31:52AM -0400, Sasha Levin wrote:
> From: Johan Hovold <johan@kernel.org>
> 
> [ Upstream commit 5d6f477d6fc0767c57c5e1e6f55a1662820eef87 ]
> 
> Make sure to deregister the controller before disabling and releasing
> underlying resources like interrupts and DMA during driver unbind.
> 
> Fixes: e8b17b5b3f30 ("spi/topcliff: Add topcliff platform controller hub (PCH) spi bus driver")
> Cc: stable@vger.kernel.org	# 2.6.37
> Cc: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> Link: https://patch.msgid.link/20260414134319.978196-8-johan@kernel.org
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/spi/spi-topcliff-pch.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index 271f3e7f834be..1a85b92e9eaa3 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -1406,6 +1406,10 @@ static void pch_spi_pd_remove(struct platform_device *plat_dev)
>  	dev_dbg(&plat_dev->dev, "%s:[ch%d] irq=%d\n",
>  		__func__, plat_dev->id, board_dat->pdev->irq);
>  
> +	spi_controller_get(data->host);
> +
> +	spi_unregister_controller(data->host);
> +
>  	if (use_dma)
>  		pch_free_dma_buf(board_dat, data);
>  
> @@ -1433,7 +1437,8 @@ static void pch_spi_pd_remove(struct platform_device *plat_dev)
>  	}
>  
>  	pci_iounmap(board_dat->pdev, data->io_remap_addr);
> -	spi_unregister_controller(data->host);
> +
> +	spi_controller_put(data->host);
>  }
>  #ifdef CONFIG_PM
>  static int pch_spi_pd_suspend(struct platform_device *pd_dev,
> -- 
> 2.53.0
> 
> 

These two did not apply at all :(