From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFA1F3E51E1 for ; Fri, 15 May 2026 08:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833791; cv=none; b=nHivwQMSjKZc6TjXBVaeQyDJ1qqz5Efbcu3r1+g0Sc+94oEckV/mAuglzImduEqXtf2ZUUS1J8yhxXEks5KHBAw22uxjZoPSubxs/HNzURRtjA4M9SQmJQPXWkIbgLRAuiRplKkyYeAU87SrEM8JLRjeLd8+wacv648WE2Z7tJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833791; c=relaxed/simple; bh=uEV2NDmVGnsRLwZULDRVxRkQU+bXq9TXBZeYCn8/VhQ=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=kBaf/WS078PZoka6eqL3DkK0cn5zHN687tCgnuWGP0LmqiOJdcOO+6PaPMzLWfzT/zcfla1/zhB9D7Mg3JGIz/UMq0bq5rlMDcbqSbaF4q1ou0p3tK8lUe2R/5e9uRArYSsiqJs/hjCbEOhu5Ydwyn1IvlaT1Tto0QQcJMmQrQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HrTFNz9a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HrTFNz9a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C5B1C2BCB8; Fri, 15 May 2026 08:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778833791; bh=uEV2NDmVGnsRLwZULDRVxRkQU+bXq9TXBZeYCn8/VhQ=; h=Subject:To:Cc:From:Date:From; b=HrTFNz9aNc4dfn6Q9fWMsWc9q2gy7w+J7jIUbd/g/spdR1bIGiljRjIVsBGX8KarY xR4BR08eD14Sfg+0gAM281rLnkqFrKbiRBaDkUk1zGraX1eqreN08ExOoHJiiLwUnD AplqHjIhHddevtJMEI4XbmnYhuAlwOCVcLJ6SFSE= Subject: FAILED: patch "[PATCH] spi: pic32-sqi: fix controller deregistration" failed to apply to 5.10-stable tree To: johan@kernel.org,broonie@kernel.org,purna.mandal@microchip.com Cc: From: Date: Fri, 15 May 2026 10:29:22 +0200 Message-ID: <2026051522-groggily-ungraded-e562@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 420df79d1a618951eb0eb4331df95c9f4f763b8b # git commit -s git send-email --to '' --in-reply-to '2026051522-groggily-ungraded-e562@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 420df79d1a618951eb0eb4331df95c9f4f763b8b Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 10 Apr 2026 10:17:37 +0200 Subject: [PATCH] spi: pic32-sqi: fix controller deregistration Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 3270ac230f66 ("spi: pic32-sqi: add SPI driver for PIC32 SQI controller.") Cc: stable@vger.kernel.org # 4.7 Cc: Purna Chandra Mandal Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-8-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c index 051590038895..41662992dbe5 100644 --- a/drivers/spi/spi-pic32-sqi.c +++ b/drivers/spi/spi-pic32-sqi.c @@ -642,7 +642,7 @@ static int pic32_sqi_probe(struct platform_device *pdev) host->prepare_transfer_hardware = pic32_sqi_prepare_hardware; host->unprepare_transfer_hardware = pic32_sqi_unprepare_hardware; - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&host->dev, "failed registering spi host\n"); free_irq(sqi->irq, sqi); @@ -665,9 +665,15 @@ static void pic32_sqi_remove(struct platform_device *pdev) { struct pic32_sqi *sqi = platform_get_drvdata(pdev); + spi_controller_get(sqi->host); + + spi_unregister_controller(sqi->host); + /* release resources */ free_irq(sqi->irq, sqi); ring_desc_ring_free(sqi); + + spi_controller_put(sqi->host); } static const struct of_device_id pic32_sqi_of_ids[] = {