From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BACA03783C7 for ; Fri, 15 May 2026 08:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778834321; cv=none; b=NSC9T/+x3Javxq8pDKSDyFUYVfKFZl2QZWvfe4FVEE6wlk2teduaN0joFzpcjivhATkidwYeNi1V1G9f3gfj9W4JmeDn8w2/1doD/5Wfu2W3cvJmgo/q8J4yh6ROD4ihZXhgLXle6gGWsLs/jrVRVsbfXcXx6m8hijZNhEUgx+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778834321; c=relaxed/simple; bh=jMfCC1YWfNTgmBLTAjmIZlDKMBbjy9gtd2o8RZN1xck=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=HsdH77SbCVw7LPq0FBtpLdb0UG6QhXlzAlt1YYeZqh3K2/bwtWz8VrOy65MAJh+CsJ22RTP/p1C0t1E3WlGseP4ueQCpS9RCc4cJgW+v0foQLw+RtNQgzARSZQmY2efKA7BmXmIKfoDFYojDv/GZ1ueDfni3OnSfire//zHfOSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J76nbFxZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J76nbFxZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EF5BC2BCB0; Fri, 15 May 2026 08:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778834321; bh=jMfCC1YWfNTgmBLTAjmIZlDKMBbjy9gtd2o8RZN1xck=; h=Subject:To:Cc:From:Date:From; b=J76nbFxZTvVTzSFaLE+cRmn1qRLI/qyKnu4/etHm6TWu9cFpDKgfcvvv4h/nzXtra FKCRIRiXYKDgvLvuQRNdmG4WYM1KMQcOc+9w9xOx/TNbmn/iX+mAtM0lyrLmFyJiT0 Oh7E/fXGx+LV6W1agxxzwQ8JjKiRJZv5gxAPPOs4= Subject: FAILED: patch "[PATCH] drm/udl: Increase GET_URB_TIMEOUT" failed to apply to 5.10-stable tree To: oushixiong@kylinos.cn,stable@vger.kernel.org,tzimmermann@suse.de Cc: From: Date: Fri, 15 May 2026 10:38:32 +0200 Message-ID: <2026051532-crispness-overhaul-5510@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x ac2c996675755c725a0065dbe3e2ebffded9080b # git commit -s git send-email --to '' --in-reply-to '2026051532-crispness-overhaul-5510@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From ac2c996675755c725a0065dbe3e2ebffded9080b Mon Sep 17 00:00:00 2001 From: Shixiong Ou Date: Fri, 24 Apr 2026 20:44:27 +0800 Subject: [PATCH] drm/udl: Increase GET_URB_TIMEOUT [WHY] A situation has occurred where udl_handle_damage() executed successfully and the kernel log appears normal, but the display fails to show any output. This is because the call to udl_get_urb() in udl_crtc_helper_atomic_enable() failed without generating any error message. [HOW] 1. Increase timeout of getting urb. 2. Add error messages when calling udl_get_urb() failed in udl_crtc_helper_atomic_enable(). Signed-off-by: Shixiong Ou Reviewed-by: Thomas Zimmermann Fixes: 5320918b9a87 ("drm/udl: initial UDL driver (v4)") Signed-off-by: Thomas Zimmermann Cc: # v3.4+ Link: https://patch.msgid.link/20260424124427.657-1-oushixiong1025@163.com diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index 08a0e9480d70..17950fe3a0ec 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -285,13 +285,12 @@ static struct urb *udl_get_urb_locked(struct udl_device *udl, long timeout) return unode->urb; } -#define GET_URB_TIMEOUT HZ struct urb *udl_get_urb(struct udl_device *udl) { struct urb *urb; spin_lock_irq(&udl->urbs.lock); - urb = udl_get_urb_locked(udl, GET_URB_TIMEOUT); + urb = udl_get_urb_locked(udl, HZ * 2); spin_unlock_irq(&udl->urbs.lock); return urb; } diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c index 231e829bd709..1ca073a4ecb2 100644 --- a/drivers/gpu/drm/udl/udl_modeset.c +++ b/drivers/gpu/drm/udl/udl_modeset.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include @@ -342,8 +343,10 @@ static void udl_crtc_helper_atomic_enable(struct drm_crtc *crtc, struct drm_atom return; urb = udl_get_urb(udl); - if (!urb) + if (!urb) { + drm_err_ratelimited(dev, "get urb failed when enabling crtc\n"); goto out; + } buf = (char *)urb->transfer_buffer; buf = udl_vidreg_lock(buf);