From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B553F0AA0 for ; Fri, 15 May 2026 07:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778830786; cv=none; b=QIjVsY+zU3wykSdqXZLCm0XzmNYpsxydw7ti93nV6VG7hF1+JVwezzhIaNJvZppPnvydu2m+xKHFgzZTxfM9CGFssfxDEtGb44Yv+3JiEavi9B+jle4x93S/jFw/N7cMRE43sf0frQsYuR4za/5XlyC0xHcVxALUwFErvkD2TXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778830786; c=relaxed/simple; bh=IPi+E9vRFooirvEWLyxQqRwE994hxDkNeMjRAYBEtzg=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=FfQwecDoUeXEzg2hCD8cD7luc801zs6IPPf1M59Q2i8byhH8RYBsEW2vKT4vBso+W3pXa2Atuv6CDXVdIRm9YtKvBtuaRLWdk7UXEK9UNdlVTJz1cicUdNgjP0ZPjkMA9qqrwnoCUfNTqQLRi8aOV3zjMJRA39D8vEUGcsv+2ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uu+OdQdo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uu+OdQdo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CDF1C2BCB0; Fri, 15 May 2026 07:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778830785; bh=IPi+E9vRFooirvEWLyxQqRwE994hxDkNeMjRAYBEtzg=; h=Subject:To:Cc:From:Date:From; b=uu+OdQdondrFddFjbmyKdJvPbrvnbWdj+zN9SWL1Sq0JuHqjhB512JfruGszEaj/6 fH1svrmS+XGLVpotHJecFDBo6uTM9fpjTZWJA+WDEuDEfzV5IN8Xda/gTQVhawLxYR k8SjjwmIhxCXyoxjov1gp8Vors+YU5kAlH0M8VhA= Subject: FAILED: patch "[PATCH] spi: pic32: fix controller deregistration" failed to apply to 5.10-stable tree To: johan@kernel.org,broonie@kernel.org,purna.mandal@microchip.com Cc: From: Date: Fri, 15 May 2026 09:39:36 +0200 Message-ID: <2026051536-plenty-croon-340f@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 6b627bfe0c44e064aba464839e430dc1ca2b0bb8 # git commit -s git send-email --to '' --in-reply-to '2026051536-plenty-croon-340f@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 6b627bfe0c44e064aba464839e430dc1ca2b0bb8 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 10 Apr 2026 10:17:36 +0200 Subject: [PATCH] spi: pic32: fix controller deregistration Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 1bcb9f8ceb67 ("spi: spi-pic32: Add PIC32 SPI master driver") Cc: stable@vger.kernel.org # 4.7 Cc: Purna Chandra Mandal Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-7-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index 369850d14313..70427e529945 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -821,7 +821,7 @@ static int pic32_spi_probe(struct platform_device *pdev) } /* register host */ - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&host->dev, "failed registering spi host\n"); goto err_bailout; @@ -840,11 +840,16 @@ static int pic32_spi_probe(struct platform_device *pdev) static void pic32_spi_remove(struct platform_device *pdev) { - struct pic32_spi *pic32s; + struct pic32_spi *pic32s = platform_get_drvdata(pdev); + + spi_controller_get(pic32s->host); + + spi_unregister_controller(pic32s->host); - pic32s = platform_get_drvdata(pdev); pic32_spi_disable(pic32s); pic32_spi_dma_unprep(pic32s); + + spi_controller_put(pic32s->host); } static const struct of_device_id pic32_spi_of_match[] = {