From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8B43FB046 for ; Fri, 15 May 2026 08:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833754; cv=none; b=R0AIX9SX7ixDx0E/3+Xw7CwJStPAC2rt3XZ0MQSOxZHV4OCDKF482uCIQzK/+GzBbvVoiJNXzGgQEF06ZSZufZOhAC8p3UoetE0MBJGkbozH1vX/94bDResMMKktja5D4ZJbypSbZ9+vSq8tH3+pvwmmNhFxPu9bpICHLRjAQ6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833754; c=relaxed/simple; bh=P4q5us/k1u1Q7FIyeuyXzI+U1P2A15xXvZ5SYucuWRc=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=tkU5fyUgaeK7lVpPZKMT5h46g5u76Ct1ucPJl3QA/ieLNcfuVwTZcInJht2OuHHtriIgV69P7KgWa00o0PEewmHmMELhjppTFg/MluWeiToeF3LV2pmcqe93UuMcFeJ5uvtGMZ3kF2TSFPbGc58V4jGBjTnccoUoM0KwD99pel4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kjQYIZFm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kjQYIZFm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5327CC2BCB0; Fri, 15 May 2026 08:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778833753; bh=P4q5us/k1u1Q7FIyeuyXzI+U1P2A15xXvZ5SYucuWRc=; h=Subject:To:Cc:From:Date:From; b=kjQYIZFmDu6mHjYOui0mV7AAAK4AtdKyjO2UWOZdwpGdTyUcl+mHZ+McFRA5jHDMv CMpoFg810CIIF54Awcmv+DslsYFWkd75GOdJFWOKYM1tQIm7Ap/h2xs0rljWIWdtMW B4ycHNwKNwLFSBY8Jkz40D9fhsK+RJtVc8mhpqYE= Subject: FAILED: patch "[PATCH] spi: coldfire-qspi: fix controller deregistration" failed to apply to 5.10-stable tree To: johan@kernel.org,broonie@kernel.org,sfking@fdwdc.com Cc: From: Date: Fri, 15 May 2026 10:28:50 +0200 Message-ID: <2026051550-serving-elsewhere-b7a7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x e7c510e192ff2a1264d999575eea39a506424264 # git commit -s git send-email --to '' --in-reply-to '2026051550-serving-elsewhere-b7a7@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From e7c510e192ff2a1264d999575eea39a506424264 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Thu, 9 Apr 2026 14:04:09 +0200 Subject: [PATCH] spi: coldfire-qspi: fix controller deregistration Make sure to deregister the controller before disabling underlying resources like clocks (via runtime pm) during driver unbind. Fixes: 34b8c6617366 ("spi: Add Freescale/Motorola Coldfire QSPI driver") Cc: stable@vger.kernel.org # 2.6.34 Cc: Steven King Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260409120419.388546-11-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c index fdf37636cb9f..b45f44de85dc 100644 --- a/drivers/spi/spi-coldfire-qspi.c +++ b/drivers/spi/spi-coldfire-qspi.c @@ -410,9 +410,9 @@ static int mcfqspi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, host); pm_runtime_enable(&pdev->dev); - status = devm_spi_register_controller(&pdev->dev, host); + status = spi_register_controller(host); if (status) { - dev_dbg(&pdev->dev, "devm_spi_register_controller failed\n"); + dev_dbg(&pdev->dev, "failed to register controller\n"); goto fail1; } @@ -436,11 +436,17 @@ static void mcfqspi_remove(struct platform_device *pdev) struct spi_controller *host = platform_get_drvdata(pdev); struct mcfqspi *mcfqspi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(&pdev->dev); /* disable the hardware (set the baud rate to 0) */ mcfqspi_wr_qmr(mcfqspi, MCFQSPI_QMR_MSTR); mcfqspi_cs_teardown(mcfqspi); + + spi_controller_put(host); } #ifdef CONFIG_PM_SLEEP