From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79DD63FB7C1 for ; Fri, 15 May 2026 08:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833710; cv=none; b=UO9DD9EFkhIYEDYSstJ2cYhxkZ6ho4pMxQyXu7tyEeFbnAOALGsJg8/uGyq9HuKuSyu78no4uHovISqEr+o2eq7ShwBRPmgeCw1SIL4M/PX96U+8PQVVTpkY0K0BZaCUt45cQux2HiY4GNdr++rsAub67GKoQLs0b4m5dsKjhFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833710; c=relaxed/simple; bh=/OZtuOk7kahoOF6bo/kmld486qz148twKjk2AnAGdK4=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=aUdb/Ldvc2epDC+h1zzW+hV5+/+WzKA7bSnloNJgb0nRLP9kn+DGETtoufH9rBhEVw90O00o0Bx2nX9v8W0I3Ahrhtx57wC5nmWPBAJkUxeB9qe4snT5o0/rnAZJflpMI/xPCnkHKv/z+7ekvGvJBhNwKFY8TeI1NwUzqpTK02w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Th1I0dQY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Th1I0dQY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65D95C2BCB8; Fri, 15 May 2026 08:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778833710; bh=/OZtuOk7kahoOF6bo/kmld486qz148twKjk2AnAGdK4=; h=Subject:To:Cc:From:Date:From; b=Th1I0dQYasmpog0qimB4REe2+nrO/FpJrDYnM6sDhe3LW3zQ6MDVEYKu+LEQw7yBk OYpLANjQf65sjAS9m2HQa+yQowAQ/jwTAbBpqHnM+/EE+7C0ik2AgvpbG9m6v1pTnt WOCedoc+CSYnPeS+dJLCEF8BxBaxbact8RVtVG0o= Subject: FAILED: patch "[PATCH] spi: sh-hspi: fix controller deregistration" failed to apply to 5.15-stable tree To: johan@kernel.org,broonie@kernel.org Cc: From: Date: Fri, 15 May 2026 10:27:56 +0200 Message-ID: <2026051556-email-expansive-3b80@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x e63982e6392e45a6ecd68d6c317a081cc8e70143 # git commit -s git send-email --to '' --in-reply-to '2026051556-email-expansive-3b80@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From e63982e6392e45a6ecd68d6c317a081cc8e70143 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 10 Apr 2026 10:17:42 +0200 Subject: [PATCH] spi: sh-hspi: fix controller deregistration Make sure to deregister the controller before releasing underlying resources like clocks during driver unbind. Fixes: 49e599b8595f ("spi: sh-hspi: control spi clock more correctly") Cc: stable@vger.kernel.org # 3.4 Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-13-johan@kernel.org Signed-off-by: Mark Brown diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index e03eaca1b1a7..1e3ca718ca73 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c @@ -257,9 +257,9 @@ static int hspi_probe(struct platform_device *pdev) ctlr->transfer_one_message = hspi_transfer_one_message; ctlr->bits_per_word_mask = SPI_BPW_MASK(8); - ret = devm_spi_register_controller(&pdev->dev, ctlr); + ret = spi_register_controller(ctlr); if (ret < 0) { - dev_err(&pdev->dev, "devm_spi_register_controller error.\n"); + dev_err(&pdev->dev, "failed to register controller\n"); goto error2; } @@ -279,9 +279,15 @@ static void hspi_remove(struct platform_device *pdev) { struct hspi_priv *hspi = platform_get_drvdata(pdev); + spi_controller_get(hspi->ctlr); + + spi_unregister_controller(hspi->ctlr); + pm_runtime_disable(&pdev->dev); clk_put(hspi->clk); + + spi_controller_put(hspi->ctlr); } static const struct of_device_id hspi_of_match[] = {