Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rishi Gupta" <gupt21@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] iio: light: veml6030: fix channel type when pushing events
Date: Sat, 16 May 2026 14:09:02 +0100	[thread overview]
Message-ID: <20260516140902.2c3135ba@jic23-huawei> (raw)
In-Reply-To: <20260514-veml6030-fixes-v2-1-abdd5837be50@gmail.com>

On Thu, 14 May 2026 14:01:11 +1300
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> The events are registered for IIO_LIGHT and not for IIO_INTENSITY.
> Use the correct channel type.
> 
> When at it, fix minor checkpatch code style warning (alignment).
> 
> Cc: stable@vger.kernel.org
> Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Applied this one to the fixes-togreg branch of iio.git.

Thanks

Jonathan

> ---
>  drivers/iio/light/veml6030.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index 6bcacae3863c..da8c32cabfd6 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -875,9 +875,11 @@ static irqreturn_t veml6030_event_handler(int irq, void *private)
>  	else
>  		evtdir = IIO_EV_DIR_FALLING;
>  
> -	iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_INTENSITY,
> -					0, IIO_EV_TYPE_THRESH, evtdir),
> -					iio_get_time_ns(indio_dev));
> +	iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_LIGHT,
> +						       0,
> +						       IIO_EV_TYPE_THRESH,
> +						       evtdir),
> +		       iio_get_time_ns(indio_dev));
>  
>  	return IRQ_HANDLED;
>  }
> 


      reply	other threads:[~2026-05-16 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  1:01 [PATCH v2 0/2] iio: light: veml6030: fix channel type for events and remove unused read Javier Carrasco
2026-05-14  1:01 ` [PATCH v2 1/2] iio: light: veml6030: fix channel type when pushing events Javier Carrasco
2026-05-16 13:09   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260516140902.2c3135ba@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gupt21@gmail.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox