From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE26171CD for ; Mon, 18 May 2026 01:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779067426; cv=none; b=L9MUeBEEA9x2f2H+PNE8hy0Ft0n4742IJg86MsmFgolOkBYoxkfbUvOrMRdJYkGXnLuvczlw59WAhIciksksCkI4VQSMA8SqKnEbZ0dZyZ1bOrCt6/gX5CxGbyD53m9w/61rS5sRYwZYsAkcJF7mDkBFJh92h9DqM5OWmvLgHKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779067426; c=relaxed/simple; bh=dLSMXHRZgtNaa1rzwvMWu56RZkyChq0eUxZuQmvonkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EESAvVNF/0cjnjxpa69YOmhWJWHM+rr6f4A+z3g6KWJpygfsa7rJlzXFhM4jNf93p/ON+u20nwtO9BfdR36+PwSo1Fa7H6OAzLpW1EJq9/1uFxg5w0Os1RI76bpdfxYXN0j+/2NtxCD14PXKvvNF5tLpxdryeaDYC2+YF6ZrWpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vBqBuGHw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vBqBuGHw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D88FBC2BCB0; Mon, 18 May 2026 01:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779067426; bh=dLSMXHRZgtNaa1rzwvMWu56RZkyChq0eUxZuQmvonkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vBqBuGHwE7R+yvnz5i3LX6i367K6Uuo1IINruoZAdvIyq04vOs2XUV5wLki3Vssro l8tkTwojVcMKSWi5k6xRgqQ3zCA794BL7kwOdbx4B0qWtnuZGTrX0vSVe5XJcgBhv7 q4BxL5EoyYsrqZLM9p92mh8pvhUsKlU8JX6HXL6StOeG3sLFJNhzJ4YVdFLmB3Ol1a xmjhwTU7vbQpjDTg8B/By3Kjba8tdLAaTKAM8dGf7+dP8kVhXXOgMauRBHBtBchR/P xycHA+5R/V91ud2SGGi6q0YxL7LkFdZKm8YEW5u1L9lTREFD9ervEg6yvrJkb5gEg/ Zp9MhL0cCZbDg== From: Sasha Levin To: stable@vger.kernel.org Cc: Jason Gunthorpe , Long Li , Sasha Levin Subject: [PATCH 6.12.y] RDMA/mana: Remove user triggerable WARN_ON() in mana_ib_create_qp_rss() Date: Sun, 17 May 2026 21:23:44 -0400 Message-ID: <20260518012344.482192-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051229-jelly-reverence-0bf5@gregkh> References: <2026051229-jelly-reverence-0bf5@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jason Gunthorpe [ Upstream commit 159f2efabc89d3f931d38f2d35876535d4abf0a3 ] Sashiko points out that the user can specify WQs sharing the same CQ as a part of the uAPI and this will trigger the WARN_ON() then go on to corrupt the kernel. Just reject it outright and fail the QP creation. Cc: stable@vger.kernel.org Fixes: c15d7802a424 ("RDMA/mana_ib: Add CQ interrupt support for RAW QP") Link: https://sashiko.dev/#/patchset/0-v2-1c49eeb88c48%2B91-rdma_udata_rep_jgg%40nvidia.com?part=1 Link: https://patch.msgid.link/r/5-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com Reviewed-by: Long Li Signed-off-by: Jason Gunthorpe [ adjusted context ] Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mana/cq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c index f04a679d28714..54cf3868b2977 100644 --- a/drivers/infiniband/hw/mana/cq.c +++ b/drivers/infiniband/hw/mana/cq.c @@ -120,8 +120,9 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq) if (cq->queue.id >= gc->max_num_cqs) return -EINVAL; - /* Create CQ table entry */ - WARN_ON(gc->cq_table[cq->queue.id]); + /* Create CQ table entry, sharing a CQ between WQs is not supported */ + if (gc->cq_table[cq->queue.id]) + return -EINVAL; gdma_cq = kzalloc(sizeof(*gdma_cq), GFP_KERNEL); if (!gdma_cq) return -ENOMEM; -- 2.53.0