From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4B4212542 for ; Mon, 18 May 2026 03:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779074871; cv=none; b=CWQmVT9YuDCBUJiReXGm5mdPwJ7XopG3SZ7rjZpMrGvQbx2vfTGy29tSXiXA9NjpVbdukCZdXQ5DxpS3Zob6A0/mU9AyfadYwp8/M1aK3FgPeb8ogtPPHadjn+LLMkLmKGYS9OgYXHzXI9NGt9wTN/iImQIUcY9Xtj2kbYI12Jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779074871; c=relaxed/simple; bh=KYR6MFAWhRhxnnLG3YzM4p15DeNAO83A5v1P+rrOYO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UBw8YRz/U445ZfSOEx9GIgkjwm5iqbTDCzH8oZNYSch6hFBRyH7/yl9qAPOEs/GT56x1uSGL626gG6nO+IK6sL98ZPMJ+tuuGxikZOn7A80QaFsD0JRzuwM2za5a4VpODKvcLtf38Gf/Uu+bAVBY2zfpUc9aVBbvkHyeNvTq7io= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kefm6Jsl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kefm6Jsl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC41FC2BCB0; Mon, 18 May 2026 03:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779074871; bh=KYR6MFAWhRhxnnLG3YzM4p15DeNAO83A5v1P+rrOYO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kefm6JslJ82AsLvVwyfappo2mjgwg4rBqN7U/mahMQ0DdS/NjjJiED7NLu5Cm5Z4l +G72z5yCvEbQUbFhyWI8W4JucGwz2d+BSF3AwT4mZuyhkpiJFZ4e3uNMF+DJD5Hz3w OqZMNr1ZkJk43AnWScixMJ0m5YVxHSftXHprGXyfVYnLAg+mxvD/EHcFDwkdGgx7w3 D0inMmn1qqDB0QcHsAgHfhBGfUNbedjsi92iotyMuxdLTiURdls/P3IcznC7luyv1p DAVYYsKfTgCyyMH8sxmI2alhQEz8bZphfjdBCIH5f6Qj0rHUpJe4JGZTH5rJDNVZtc ieSjPqZ1r6v9g== From: Sasha Levin To: stable@vger.kernel.org Cc: Tejun Heo , Chris Mason , Andrea Righi , Sasha Levin Subject: [PATCH 7.0.y] sched_ext: Pass held rq to SCX_CALL_OP() for core_sched_before Date: Sun, 17 May 2026 23:27:48 -0400 Message-ID: <20260518032748.587324-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051216-herbs-deranged-aad5@gregkh> References: <2026051216-herbs-deranged-aad5@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tejun Heo [ Upstream commit 4155fb489fa175ec74eedde7d02219cf2fe74303 ] scx_prio_less() runs from core-sched's pick_next_task() path with rq locked but invokes ops.core_sched_before() with NULL locked_rq, leaving scx_locked_rq_state NULL. If the BPF callback calls a kfunc that re-acquires rq based on scx_locked_rq() - e.g. scx_bpf_cpuperf_set(cpu) - it re-acquires the already-held rq. Pass task_rq(a). Fixes: 7b0888b7cc19 ("sched_ext: Implement core-sched support") Cc: stable@vger.kernel.org # v6.12+ Reported-by: Chris Mason Signed-off-by: Tejun Heo Reviewed-by: Andrea Righi [ adapted call to use stable's single `sch`/`SCX_KF_REST` mask and `scx_rq_bypassing(task_rq(a))` signature ] Signed-off-by: Sasha Levin --- kernel/sched/ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 9c7ff5179e4f1..39a70bdfd507f 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -2655,7 +2655,7 @@ bool scx_prio_less(const struct task_struct *a, const struct task_struct *b, if (SCX_HAS_OP(sch, core_sched_before) && !scx_rq_bypassing(task_rq(a))) return SCX_CALL_OP_2TASKS_RET(sch, SCX_KF_REST, core_sched_before, - NULL, + task_rq(a), (struct task_struct *)a, (struct task_struct *)b); else -- 2.53.0