From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C553382383; Mon, 18 May 2026 19:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779132064; cv=none; b=ANiEmqY0EnCye0GTz9JP69rr8ivHEI9+r3fPBrq6HVmuqtQzRjaCJ94qCH5IrPgrYTJjKOevulZx4c4ceByy5PYM3o/WkUU5QN5dzMEfSzeRR0I8SB9PQS511gm77kWyo2KwVekdYHDUKH7dAAuAh1RT/6rxP+R7TUVirgn6vWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779132064; c=relaxed/simple; bh=VVi36MaIcMpmXO2pTePxfZQYLgCz6lO1mEvbzN8lcwE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M0vE2aYDzB4ViJpGMF95MYC34LjBEpXPze2iF7cbR8JO6FbIEqet/w8VVWiO4XqXRodUJtNZBRbEty/WGQU/nLtokdXKeW8cqXbarwf65TF40mSyIyQDVXjfNbd0U5vERDcPVdFjjd0Bw0DwyxTa5RC8Gmt19qwsQWrE+bnFj30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oC82EE9a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oC82EE9a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1731FC2BCB7; Mon, 18 May 2026 19:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779132064; bh=VVi36MaIcMpmXO2pTePxfZQYLgCz6lO1mEvbzN8lcwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oC82EE9a8H3zhVsVatoigkVvWGCDHj3SnmMI+CLXLlBwhhhWtwT+/+7U0ueGekhCU TR8pzHbjNv9MlMxtbTAZ4Tw/lZgBWSv3sqwiDAyAGqiobawL0QF1bkvkLPaqm9ScAO wm+wqTyomNQO4mjUvlhnwx8cEC4jH7HRlexxfs01OCda+ZQ3ZFZ9OQ32UNxXRbsLl2 xTY9E+5H0MitWgTI6gaBPzJxj+3NHD8vOWb9Tv5tGvIQw7oeeO6qqkmkX7s1oRIldi dpkAhEN5RfQ4f8tt2LV+d4+M0oh0h4RuWSR5P5Kh5gpHS8W50Wq6hLhj6qK4I/O6c6 RpeZoJwNdWFIg== From: Sasha Levin To: gregkh@linuxfoundation.org Cc: Sasha Levin , ardb@kernel.org, herbert@gondor.apana.org.au, patches@lists.linux.dev, stable@vger.kernel.org, dist-kernel@gentoo.org, kernel@gentoo.org, Sam James Subject: Re: [PATCH 6.6 404/474] crypto: nx - Migrate to scomp API Date: Mon, 18 May 2026 15:20:50 -0400 Message-ID: <20260518155236.reply-0001@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <87y0hha5dw.fsf@gentoo.org> References: <87y0hha5dw.fsf@gentoo.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, May 17, 2026, Sam James wrote: > This fails to build. I think it's this patch. I did try figure out why > but I couldn't spot it when comparing branches (and all other branches > are fine). > > /var/tmp/portage/sys-kernel/gentoo-kernel-6.6.140/work/linux-6.6/drivers/crypto/nx/nx-common-pseries.c:1023:35: error: initialization of 'void * (*)(struct crypto_scomp *)' from incompatible pointer type 'void * (*)(void)' [-Wincompatible-pointer-types] Thanks Sam. The root cause is that upstream 980b5705f4e7 ("crypto: nx - Migrate to scomp API") was written against the post-v6.6 simplified scomp API (alloc_ctx(void) / free_ctx(void *)), whereas v6.6 still uses the older alloc_ctx(struct crypto_scomp *tfm) / free_ctx(struct crypto_scomp *, void *) prototypes. The migration was pulled in as Stable-dep-of for adb3faf2db1a, but that fix does not actually require the scomp migration. I've dropped all three crypto/nx commits from pending-6.6 in this cycle: - 268ae55a4c4fb ("crypto: nx - Migrate to scomp API") - b94588f5a6971 ("crypto: nx - fix context leak in nx842_crypto_free_ctx") - 6923cde8dc1d5 ("crypto: nx - fix bounce buffer leaks in nx842_crypto_{alloc,free}_ctx") The bounce-buffer fix (adb3faf2db1a) has been re-queued as a backport against pre-scomp 6.6 nx-842.c (using the same adaptation already shipped in 6.12.y as 910bb34b801d3). -- Thanks, Sasha