From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AD96352000 for ; Tue, 19 May 2026 11:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779191542; cv=none; b=J+9RqJK4OIpvby6H7Ys14DT0qFuuyCnna1yYMLdnymU3qgRc9dXPIk7reTB1+mXg14ZzdM7ngP/Ql8G9Kk6XbJroLZYKCukUJQtYLgbe2VcH6JqSEyg00tKBy6FtsQkP6V8artwJxq/s+HrGrAGh3T0289uJmRaocbo84uw9PjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779191542; c=relaxed/simple; bh=aotQKa+DLVv8M0Ix3Y7PnrfO0B/7faA6/2y7heoqt44=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UcsTrFCCi7w3c6Cd5d44jtmgsK3QRanB9JwVbeZJKpvIKOf76NvNeX9VMzO/IN67VdV4FXV9uCMnOej/zvO3SNYv4dyQ9aD6o31H+6rXtW+518KN2m31u6RRsHziVQwpk2Io/scTlhOkJntjIbMl7GYv20MxP4mec6ZYV4XRLgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p1XEP+xS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p1XEP+xS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4856C2BCB3; Tue, 19 May 2026 11:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779191542; bh=aotQKa+DLVv8M0Ix3Y7PnrfO0B/7faA6/2y7heoqt44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p1XEP+xSAPDqtJEi/WDDAh8NsfF3R+h60AsOJeyPAis9XVJc8sPHiITvGAYI70yHC 33ygH1MMorHxQo22k5nIpcifsOuLVnp9KD7WR4FVpWSX7hlCO36ZBrGr8fKsZ5tNfZ 0Uj5rY5h6l0sPXiZt6iIjai2e4gg87dX7vRpVg/brzMiog00zgrUQ0YCeh2d5KfhbQ HFkqsAC2WkWaTSIFmaPJFAxN3pEZRGreul8aiKLPKuvYFjRRfuHkqU4GWoBVr+acmG CxtLMn8wxsi3aszT+RNWqtVYuQ5ZhiENWusVSokp5CVu1Suk3Bx3qclDILIwJ12iwy f7cGxuBHSUodA== From: Sasha Levin To: stable@vger.kernel.org Cc: "Matthieu Baerts (NGI0)" , Mat Martineau , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6.y] mptcp: pm: ADD_ADDR rtx: resched blocked ADD_ADDR quicker Date: Tue, 19 May 2026 07:52:19 -0400 Message-ID: <20260519115219.2240625-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026051253-pebble-detergent-76b0@gregkh> References: <2026051253-pebble-detergent-76b0@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Matthieu Baerts (NGI0)" [ Upstream commit 3cf12492891c4b5ff54dda404a2de4ec54c9e1b5 ] When an ADD_ADDR needs to be retransmitted and another one has already been prepared -- e.g. multiple ADD_ADDRs have been sent in a row and need to be retransmitted later -- this additional retransmission will need to wait. In this case, the timer was reset to TCP_RTO_MAX / 8, which is ~15 seconds. This delay is unnecessary long: it should just be rescheduled at the next opportunity, e.g. after the retransmission timeout. Without this modification, some issues can be seen from time to time in the selftests when multiple ADD_ADDRs are sent, and the host takes time to process them, e.g. the "signal addresses, ADD_ADDR timeout" MPTCP Join selftest, especially with a debug kernel config. Note that on older kernels, 'timeout' is not available. It should be enough to replace it by one second (HZ). Fixes: 00cfd77b9063 ("mptcp: retransmit ADD_ADDR when timeout") Cc: stable@vger.kernel.org Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20260505-net-mptcp-pm-fixes-7-1-rc3-v1-6-fca8091060a4@kernel.org Signed-off-by: Jakub Kicinski [ replaced `TCP_RTO_MAX / 8` with `HZ` ] Signed-off-by: Sasha Levin --- net/mptcp/pm_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 28f8d7fb7bdf3..5feb57d6eb5eb 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -309,7 +309,7 @@ static void mptcp_pm_add_timer(struct timer_list *timer) return; if (mptcp_pm_should_add_signal_addr(msk)) { - sk_reset_timer(sk, timer, jiffies + TCP_RTO_MAX / 8); + sk_reset_timer(sk, timer, jiffies + HZ); goto out; } -- 2.53.0