From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A51C3EDAC6; Wed, 20 May 2026 18:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301772; cv=none; b=mZoc2LvF4eJvLq9jIl450F7r2Bs5TbSD+yHiaJ3yG0Xc5ZQqsIedkrDW1eeXXQVaURMy8q1TZMBRME32SWuvxFHQXR9aGELWLFCQIXhbfdM5qUblnq7jaA4EupGJePcicG5i3MwgSf6GkBm0m+7+B1BX+NdSLiEMpEOt60X8HCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301772; c=relaxed/simple; bh=IBcd3MJsb4mytmbM3kb8dmNVwyIM3JpWBXj78TBIvb8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ouJksht3+kNmGgN+dXdWWWpUfjtegQBaVAEcS4T8QjVkYjpidH+QPkH7GlI+dl84byv4wyFIBhzasbMn3vebU28r9+l7uG9V+9b28TotHgtD6efSH/qJSt2zgd8rLAIRkcs3SoTZFxADICdkzpOikykqDhNyWbVHvw6TS1aDkyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NHH0z0+R; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NHH0z0+R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A79C11F000E9; Wed, 20 May 2026 18:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779301771; bh=61rB2SJTh0SmJLwM1tA45fSAsHYzFEatJ06WG0TYV0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NHH0z0+R8VIVxoyUIxa3VldMaMKE3L6Cf1DnCTLMRpWk7pOsmkfZd7NtPQZVWt5ik zOPN6XmtO2f5vAzxncdFrh1VuC5PY1nXHWPJKdtCn8YlLuYQOPhCBjAQ93FfSjkZYV gvHobpeyLnn2z4qfSw4Ox1BSdhN20kQYdNSPqZEQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vineeth Vijayan , Peter Oberparleiter , Li Zhijian , Heiko Carstens , Alexander Gordeev , Sasha Levin Subject: [PATCH 6.6 015/508] s390/cio: convert sprintf()/snprintf() to sysfs_emit() Date: Wed, 20 May 2026 18:17:18 +0200 Message-ID: <20260520162058.916180473@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162058.573354582@linuxfoundation.org> References: <20260520162058.573354582@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Li Zhijian [ Upstream commit aaebea959efb2cccd870990f1b6016ff324b0fb6 ] Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). Generally, this patch is generated by make coccicheck M= MODE=patch \ COCCI=scripts/coccinelle/api/device_attr_show.cocci No functional change intended. Cc: Vineeth Vijayan Cc: Peter Oberparleiter Signed-off-by: Li Zhijian Link: https://lore.kernel.org/r/20240314095209.1325229-1-lizhijian@fujitsu.com Signed-off-by: Heiko Carstens Signed-off-by: Alexander Gordeev Stable-dep-of: ac4d8bb6e2e1 ("s390/cio: use generic driver_override infrastructure") Signed-off-by: Sasha Levin --- drivers/s390/cio/css.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c index 4e63e6d45e6e1..36c46c7f2fb80 100644 --- a/drivers/s390/cio/css.c +++ b/drivers/s390/cio/css.c @@ -309,7 +309,7 @@ static ssize_t type_show(struct device *dev, struct device_attribute *attr, { struct subchannel *sch = to_subchannel(dev); - return sprintf(buf, "%01x\n", sch->st); + return sysfs_emit(buf, "%01x\n", sch->st); } static DEVICE_ATTR_RO(type); @@ -319,7 +319,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, { struct subchannel *sch = to_subchannel(dev); - return sprintf(buf, "css:t%01X\n", sch->st); + return sysfs_emit(buf, "css:t%01X\n", sch->st); } static DEVICE_ATTR_RO(modalias); @@ -345,7 +345,7 @@ static ssize_t driver_override_show(struct device *dev, ssize_t len; device_lock(dev); - len = snprintf(buf, PAGE_SIZE, "%s\n", sch->driver_override); + len = sysfs_emit(buf, "%s\n", sch->driver_override); device_unlock(dev); return len; } @@ -396,8 +396,8 @@ static ssize_t pimpampom_show(struct device *dev, struct subchannel *sch = to_subchannel(dev); struct pmcw *pmcw = &sch->schib.pmcw; - return sprintf(buf, "%02x %02x %02x\n", - pmcw->pim, pmcw->pam, pmcw->pom); + return sysfs_emit(buf, "%02x %02x %02x\n", + pmcw->pim, pmcw->pam, pmcw->pom); } static DEVICE_ATTR_RO(pimpampom); @@ -881,7 +881,7 @@ static ssize_t real_cssid_show(struct device *dev, struct device_attribute *a, if (!css->id_valid) return -EINVAL; - return sprintf(buf, "%x\n", css->cssid); + return sysfs_emit(buf, "%x\n", css->cssid); } static DEVICE_ATTR_RO(real_cssid); @@ -904,7 +904,7 @@ static ssize_t cm_enable_show(struct device *dev, struct device_attribute *a, int ret; mutex_lock(&css->mutex); - ret = sprintf(buf, "%x\n", css->cm_enabled); + ret = sysfs_emit(buf, "%x\n", css->cm_enabled); mutex_unlock(&css->mutex); return ret; } -- 2.53.0