From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B90340A57; Wed, 20 May 2026 18:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301844; cv=none; b=IO7SK7lilpKDzP6H52hg1FGWcz01w0OBb7UehfjaHkzawJympMV4IbvuxPeimnZLintlEY7qqap+1TtBdjJleSku4yBtesQjChrhnHRUDDDifut+WYHvgfikQcxuP+ydZq2tUXueqYNVf9p90fqslDS6kVOuyVk0ZNErnUVmQI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301844; c=relaxed/simple; bh=zm66hooMOteTwnEmrZkOMalvG8ewLBo/Mi0KyIoxszg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dTb+jD/sDTDj3pXVQgfle1UJt4jm4OgbMgFNr6QJ330K+tenx9W7O8fYEvDPWqTcnm2VWmR0u7SfmyZASiQqmswFynFMlZGWtsrazXVnVlp6DDx9/vmJ7lwVv3FMgS9LBLeRfg1TAFbKu056xh70PDmPHCSWM4B31J88DGHBGOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nG+B0USz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nG+B0USz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A4581F000E9; Wed, 20 May 2026 18:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779301842; bh=TlWkofBYu+4jIui6HgFWdL3fWUmXiCdJ3/0+F7uJ5bI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nG+B0USzZglY8/MRtLi67Dbrbb7mNT+DjMd20iyvg+4u5ZGYWzMVY5uvbJzNmuny6 asYVdF7JcfGN1EqhmFVhZWP3Tty3cJt5Cn/aBtxlD/z7QeVRWYP/MQ60lHSQlzPH0L BYCHm9teSkFufOh/KpjaV56rQAC7OTHy8kulIW0I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chih Kai Hsu , Hayes Wang , Paolo Abeni , Sasha Levin Subject: [PATCH 6.6 042/508] r8152: fix incorrect register write to USB_UPHY_XTAL Date: Wed, 20 May 2026 18:17:45 +0200 Message-ID: <20260520162059.504845407@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162058.573354582@linuxfoundation.org> References: <20260520162058.573354582@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chih Kai Hsu [ Upstream commit 48afd5124fd6129c46fd12cb06155384b1c4a0c4 ] The old code used ocp_write_byte() to clear the OOBS_POLLING bit (BIT(8)) in the USB_UPHY_XTAL register, but this doesn't correctly clear a bit in the upper byte of the 16-bit register. Fix this by using ocp_write_word() instead. Fixes: 195aae321c82 ("r8152: support new chips") Signed-off-by: Chih Kai Hsu Reviewed-by: Hayes Wang Link: https://patch.msgid.link/20260326073925.32976-454-nic_swsd@realtek.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 91cf24fb5531f..d39d66e25b01b 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -3859,7 +3859,7 @@ static void r8156_ups_en(struct r8152 *tp, bool enable) case RTL_VER_15: ocp_data = ocp_read_word(tp, MCU_TYPE_USB, USB_UPHY_XTAL); ocp_data &= ~OOBS_POLLING; - ocp_write_byte(tp, MCU_TYPE_USB, USB_UPHY_XTAL, ocp_data); + ocp_write_word(tp, MCU_TYPE_USB, USB_UPHY_XTAL, ocp_data); break; default: break; -- 2.53.0