From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E4E371CEA; Wed, 20 May 2026 18:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302107; cv=none; b=VbxxNjmoZIyVC78EDl1C6M1V5EkHSTyBnhi8OXcKLT2WjjMCvBd3Cc+H8UkjTcgEdCWoBYTFpzGgWl5KFlJ6xqFLD0C1x51n59/N1lZn0+5iRTmE5QeBIE7f3kDmjx2fnDHQUqFRPZmd2tu6CaZKT2fTvUe3tasXaut7bEDV0Oo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302107; c=relaxed/simple; bh=MfaUkgYhqJgcdJZaw7xRubRjir6M/qCNn2+AC63khQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LQozceDjo1BlPf+N7EvNIKYNcXZcYHvH3JPQSK032IaG+kh8i4qMNNpepLwNpDgNBGDEPvaGTEWmsuA9tE4reuCFnmKlo6XourM+a0BTbrkW1e0dfRz8kawqkS8Dg0hBUTGj09mq6+K/kSFpuXb8n6x5AIzUfUf0Le2PojEuyTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mYrWabGe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mYrWabGe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 268261F000E9; Wed, 20 May 2026 18:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779302106; bh=Y7n025+/Mcp12YBGUPxhx3rHTD8UluqwNENIcZuY9eI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mYrWabGeCtSUMy/karf362HDl9PLscRt9ircksrx9TFPFONu7CM7sqI3Tu7ZCtSN5 nAv9S+4Fj99FPzczh09s1LCklrodC3OCcHBX/tKqiIoUwMfjapt+exT5wSMXNMxlJI c6Xvj/8NpirAfKbQgIgKHtk18daHfbxZ8bYlhDJ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shengjiu Wang , Mark Brown , Sasha Levin Subject: [PATCH 6.6 141/508] ASoC: fsl_xcvr: Fix event generation in fsl_xcvr_arc_mode_put() Date: Wed, 20 May 2026 18:19:24 +0200 Message-ID: <20260520162101.686762059@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162058.573354582@linuxfoundation.org> References: <20260520162058.573354582@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shengjiu Wang [ Upstream commit 1b61c8103c9317a9c37fe544c2d83cee1c281149 ] ALSA controls should return 1 if the value in the control changed but the control put operation fsl_xcvr_arc_mode_put() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the arc_mode variable. Fixes: 28564486866f ("ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver") Signed-off-by: Shengjiu Wang Link: https://patch.msgid.link/20260401094226.2900532-8-shengjiu.wang@nxp.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_xcvr.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 90a0a24c05d84..87ea3abc4416f 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -98,10 +98,17 @@ static int fsl_xcvr_arc_mode_put(struct snd_kcontrol *kcontrol, struct fsl_xcvr *xcvr = snd_soc_dai_get_drvdata(dai); struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; unsigned int *item = ucontrol->value.enumerated.item; + int val = snd_soc_enum_item_to_val(e, item[0]); + int ret; - xcvr->arc_mode = snd_soc_enum_item_to_val(e, item[0]); + if (val < 0 || val > 1) + return -EINVAL; - return 0; + ret = (xcvr->arc_mode != val); + + xcvr->arc_mode = val; + + return ret; } static int fsl_xcvr_arc_mode_get(struct snd_kcontrol *kcontrol, -- 2.53.0