From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DABB646AF27; Wed, 20 May 2026 18:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302386; cv=none; b=e1EAfkSYkXmm7RpTwJCjC07qmr1IE7KX+RFj26I58oSVYzvm5JfthdAVDUVAomhGpVPiTrqt+B+V1EQuXvZlKYjpJNY6F77SfipMyUjGs6ISX79au3U7JmhIaVaaGw/lhh7aFpS/WGt/XeAFzhCITPkn9Uzu3zbGagsy0nj5540= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779302386; c=relaxed/simple; bh=yvgN41uy719eykOhzEiNBLjWgxcTimi1ljPcIp78Xh8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HZSujbvN/P6OeBCIynWBaWzQG1+1uhQOVicg74VXAkgCKPrDuK/sMSNLgEwsKLWUzISc5KPOeJMTaJJxkahuollP3GhbiyBX59pDJc2qqX2/Ltgj23WHIBeswEFcoEyZZu5phZKjsdoZM4MwJlLIGB6MHn0lRq3occxqv0m5T3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1eMktbTT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1eMktbTT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AB991F00893; Wed, 20 May 2026 18:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779302385; bh=0LsYoF3SwXhyMRh2ncyjbTOV4IbyrZ0yzEyo8FJUUqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1eMktbTTrAjex/B0z0cFQ+EJtDj83eLJFlqipbV2IHdbAxD6V9iLU8S7JMsjhmfqh 34/EkHSXCcVBvdoGcFxhH9ImaBdBpc0EG6eWh1MMLrONinj/DlCceU6xi7HhJBnNXy 3j/5sNO4XkN+Dn/9ffb7mFVZGqN+mx0MdeV3/PO8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Shevchenko , Linus Walleij , Sasha Levin Subject: [PATCH 6.6 246/508] pinctrl: cy8c95x0: Unify messages with help of dev_err_probe() Date: Wed, 20 May 2026 18:21:09 +0200 Message-ID: <20260520162103.981302494@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162058.573354582@linuxfoundation.org> References: <20260520162058.573354582@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko [ Upstream commit 014884732095b982412d13d3220c3fe8483b9b3e ] Unify error messages that might appear during probe phase by switching to use dev_err_probe(). Signed-off-by: Andy Shevchenko Signed-off-by: Linus Walleij Stable-dep-of: 5ad32c3607cf ("pinctrl: cy8c95x0: Avoid returning positive values to user space") Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-cy8c95x0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 97eeaae17f669..1432b6714dc69 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1262,10 +1262,8 @@ static int cy8c95x0_irq_setup(struct cy8c95x0_pinctrl *chip, int irq) /* Read IRQ status register to clear all pending interrupts */ ret = cy8c95x0_irq_pending(chip, pending_irqs); - if (ret) { - dev_err(chip->dev, "failed to clear irq status register\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to clear irq status register\n"); /* Mask all interrupts */ bitmap_fill(chip->irq_mask, MAX_LINE); -- 2.53.0