From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69B942F363F; Wed, 20 May 2026 18:08:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779300508; cv=none; b=Elnb/MZBczwLYepTEKHuHt/BWxk5Gx+8xp2lf0VQkw0UrhTDN+Lz1LhegiXi++JL7gbqx4d+4+yb3RBaJbUI3VsoNz0yi/lPLNMSXTzHu0svVgxroys0L5mxS6yeV8gXVtQMoky+VgprAFhCYCs1aPL0wQx6134Wj2DuGeSGGwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779300508; c=relaxed/simple; bh=FnHAZc82NITFhwIh37ZJ0Q/+IYaFlHLWPOoZnxNaQ8I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RJTSCMaKnBXxuDfgUS0JCcYfy8+HfJnuPX7JC7yjwVLRz8s9qd9me0myz59BVknODDPkh+DEWQn727enFmkRgltkj2Kga9luHeqrDWHl2nDPgsdOkkedd0umaposMnZVS3E0johYN3a10w4cWrN2Qta2zt0iYwqLV5EX87Sp5FM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VVQZdqJZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VVQZdqJZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C54F1F000E9; Wed, 20 May 2026 18:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779300507; bh=E5ePk5OfwfqD+fJ17rsTP0XKTpkQEhmBZDxBgrHKQQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VVQZdqJZlUOrDcLGKQkhHPIPLUrU6snqy5fw0V9A3ShHDu+QMe8OMV9cq42OquH0D Y4q3kVpraEqrLzVz+Nw9oBrKjW2XKHxs4oZvSK+r9UdFyjy1FCs1+THpnEYILUyPeH Is+3mq04ffGrLOYM3RMuTO47Jee4meB4382wXE98= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shengjiu Wang , Mark Brown , Sasha Levin Subject: [PATCH 6.12 200/666] ASoC: fsl_micfil: Fix event generation in hwvad_put_init_mode() Date: Wed, 20 May 2026 18:16:51 +0200 Message-ID: <20260520162115.538812794@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162111.222830634@linuxfoundation.org> References: <20260520162111.222830634@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shengjiu Wang [ Upstream commit 7e226209906906421f0d952d7304e48fdb0adabc ] ALSA controls should return 1 if the value in the control changed but the control put operation hwvad_put_init_mode() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the vad_init_mode variable. Fixes: 29dbfeecab85 ("ASoC: fsl_micfil: Add Hardware Voice Activity Detector support") Signed-off-by: Shengjiu Wang Link: https://patch.msgid.link/20260401094226.2900532-4-shengjiu.wang@nxp.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_micfil.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 6fc94cafc9da8..47b8688605fa6 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -307,13 +307,18 @@ static int hwvad_put_init_mode(struct snd_kcontrol *kcontrol, unsigned int *item = ucontrol->value.enumerated.item; struct fsl_micfil *micfil = snd_soc_component_get_drvdata(comp); int val = snd_soc_enum_item_to_val(e, item[0]); + bool change = false; + + if (val < MICFIL_HWVAD_ENVELOPE_MODE || val > MICFIL_HWVAD_ENERGY_MODE) + return -EINVAL; /* 0 - Envelope-based Mode * 1 - Energy-based Mode */ + change = (micfil->vad_init_mode != val); micfil->vad_init_mode = val; - return 0; + return change; } static int hwvad_get_init_mode(struct snd_kcontrol *kcontrol, -- 2.53.0