From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE90371048; Wed, 20 May 2026 18:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301387; cv=none; b=YJu9887NrU5fzf/GpSqrqKUZPXxIKg98LNrlcxOVveW9qQvJKATNbHR3EPtJOEalAw1u1cdInONTvEp4uBoenFoB3/Qb1xzzoLQGXZmKOT3S43uMfUaA8J6eRuPdUzKHL+g3dxFgAw3IGtsy5w8Q73w4HoImitgyvdc4K0REJpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779301387; c=relaxed/simple; bh=030YpAR84HHFmjmez+kRFKQX/bf6AgjyTfueN+dcYLg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YfACSh7As32FUGU9cv0IBDqSSuOy1X5uX7UudnZswSbmF426yxAbG6R2r1wFnhXwgPaLXiIFYOQQNmtHeaK9mQ3Y9m7jW5ipqmuMbKkxljZQKmZFA9qADPLq9dPVR1BHfAeY3QuE8aKdkJcGjr9vQHkdCJhp9Bwh9p8um8xsGtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tXwFyHyj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tXwFyHyj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EC6F1F000E9; Wed, 20 May 2026 18:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779301386; bh=9pwiTznil+xRsBbWbJRpj4glrG9cZWPkX6+XmzqEbqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tXwFyHyjiU1G+BsyBPEgClrTkysytYbT2nLtpv5zsSGQG5WQ2S9G/PKDbRN62yaag /xvbMlKGg5EIzhUpE1nA0ewnfrR1P44SLqfhw20M0+1/KHxpjOON+vpqef1DYmUfvh C3v9fU0kChrSj53SoGpqmziIP3qQlt2vCSjR5lsk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stephen Hemminger , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 536/666] net/sched: netem: check for negative latency and jitter Date: Wed, 20 May 2026 18:22:27 +0200 Message-ID: <20260520162122.888432262@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162111.222830634@linuxfoundation.org> References: <20260520162111.222830634@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephen Hemminger [ Upstream commit 90be9fedb218ee95a1cf59050d1306fbfb0e8b87 ] Reject requests with negative latency or jitter. A negative value added to current timestamp (u64) wraps to an enormous time_to_send, disabling dequeue. The original UAPI used u32 for these values; the conversion to 64-bit time values via TCA_NETEM_LATENCY64 and TCA_NETEM_JITTER64 allowed signed values to reach the kernel without validation. Jitter is already silently clamped by an abs() in netem_change(); that abs() can be removed in a follow-up once this rejection is in place. Fixes: 99803171ef04 ("netem: add uapi to express delay and jitter in nanoseconds") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260418032027.900913-7-stephen@networkplumber.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sched/sch_netem.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 543a043f84f41..498c18d7d9c39 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -824,6 +824,16 @@ static int get_dist_table(struct disttable **tbl, const struct nlattr *attr) return 0; } +static int validate_time(const struct nlattr *attr, const char *name, + struct netlink_ext_ack *extack) +{ + if (nla_get_s64(attr) < 0) { + NL_SET_ERR_MSG_ATTR_FMT(extack, attr, "negative %s", name); + return -EINVAL; + } + return 0; +} + static int validate_slot(const struct nlattr *attr, struct netlink_ext_ack *extack) { const struct tc_netem_slot *c = nla_data(attr); @@ -1066,6 +1076,18 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt, goto table_free; } + if (tb[TCA_NETEM_LATENCY64]) { + ret = validate_time(tb[TCA_NETEM_LATENCY64], "latency", extack); + if (ret) + goto table_free; + } + + if (tb[TCA_NETEM_JITTER64]) { + ret = validate_time(tb[TCA_NETEM_JITTER64], "jitter", extack); + if (ret) + goto table_free; + } + sch_tree_lock(sch); /* backup q->clg and q->loss_model */ old_clg = q->clg; -- 2.53.0