From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45CC33D8137; Wed, 20 May 2026 17:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298166; cv=none; b=D3HdBA3CsuN2exS0h322Qx/jP/p0SQ/dzwZX81f4MKSjxs6tbifervcKRzlagIEmCMJdbTM/xOKtWfvn9eGM+BLDZ9wqfalPy1GCdr3SzaDh221M1LJcNATRkTGzfPOuIfyuaKP3XvSNOC/UJBxg6h3I025diTjj2o0lFI0z8xM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298166; c=relaxed/simple; bh=Sm7oZG751OzxnWdUTump7lfhwm+Q63eyTOOo+nL3bK4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eujM3X8TWL+b9bX/vynmcVBLnEZM5BmmxtkdUi91QbFMa0AHowIcNfJpjV/eDKuAQh2oTc6/RGMBEXOCgSSS6izIEQgY+9ef2dhcF4X8VQ/C6YSFDyl4Vc8BlwXIKGTXsN8L2L9EXWE0pS2WnxuJ0KqeDk6J3JU7fds89qskxjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tRxsomrU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tRxsomrU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA5EE1F000E9; Wed, 20 May 2026 17:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779298165; bh=jv5JDZR+bEI4TRmwJgKiZTLiFl4nRct1hKVezLmEVYM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tRxsomrUoObp1Hcz5ExSJjH5jR/YQqi0qpysIIxh084O2jmja4fzgc4u3fW7eKf2k DU1SV7H4QuFkEHMGM9s/D5TEbEnKR2zskUpOQaFrI1m8FV0ivHjZ9aFRpQ3n2wlyBC 3cQoZrT2f+VhN+QTGnomO/MSrOtmlftvctdUGmEI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Timur=20Krist=C3=B3f?= , Alex Deucher , Sasha Levin Subject: [PATCH 6.18 265/957] drm/amd/pm/ci: Fill DW8 fields from SMC Date: Wed, 20 May 2026 18:12:28 +0200 Message-ID: <20260520162140.291038681@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Timur Kristóf [ Upstream commit baf28ec5795c077406d6f52b8ad39e614153bce6 ] In ci_populate_dw8() we currently just read a value from the SMU and then throw it away. Instead of throwing away the value, we should use it to fill other fields in DW8 (like radeon). Otherwise the value of the other fiels is just cleared when we copy this data to the SMU later. Fixes: 9f4b35411cfe ("drm/amd/powerplay: add CI asics support to smumgr (v3)") Signed-off-by: Timur Kristóf Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c index 1494143132eb5..aea3ad523cc03 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c @@ -543,12 +543,11 @@ static int ci_populate_dw8(struct pp_hwmgr *hwmgr, uint32_t fuse_table_offset) { struct ci_smumgr *smu_data = (struct ci_smumgr *)(hwmgr->smu_backend); const struct ci_pt_defaults *defaults = smu_data->power_tune_defaults; - uint32_t temp; if (ci_read_smc_sram_dword(hwmgr, fuse_table_offset + offsetof(SMU7_Discrete_PmFuses, TdcWaterfallCtl), - (uint32_t *)&temp, SMC_RAM_END)) + (uint32_t *)&smu_data->power_tune_table.TdcWaterfallCtl, SMC_RAM_END)) PP_ASSERT_WITH_CODE(false, "Attempt to read PmFuses.DW6 (SviLoadLineEn) from SMC Failed!", return -EINVAL); -- 2.53.0