From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 469E33D75D3; Wed, 20 May 2026 17:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298639; cv=none; b=IVhuYx0XAt0nyg2hHqEtG8GX6UEp6s/bNO7f79NNebFaTgD6QwuaFdr1SPWUYK8NO53+tuApXjYF5gbff7/hPcSgM3XEYlphjlO0fCkjT6KFXhyHh4cujAxzJ+7laDcs0VuEomKeCeLLnAgkmivWuzwjpItHfgStcB4sH8UgeJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298639; c=relaxed/simple; bh=gholXF8PJQMLBKvjQGLHeNB3Y1HuK7SGjcV5ifNO1yw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uwGJzHwptMgR4GG30bmdqQ1uE6twuw8YWHJiwtaXzQCcA37OroHJj9Vvai/vOYbu8hWla3TPt8EaHcbehzhXKIMXsGUEI6bjtNGA8Fb7HYVMwiRBbFBnVaKc+OqoxeepUtYL80aUBKx026eA0xGJboy5bKqWKuWeWGeKT9aCLjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OTSPw2Lv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OTSPw2Lv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EBA21F00893; Wed, 20 May 2026 17:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779298638; bh=7asWGhsIxknyM7qApuYzqBJa4qUi/xFzxlfsVfea6OI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OTSPw2Lv0BzIui8RbldwazhGggaQdwZ71DEDWHXNczEqjNjsVH+ds9VuLsmLBH/Wu Rp544tRKg5+u5z68JNxnU9D4wO6SkfwIkpol1EY0estj2JQofYEfj2Z0VPxTWYaeU5 V8Nk9zvrnyNT5sjC5n02+o/qHixaQFsQs8HMxgvg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Khairul Anuar Romli , Vinod Koul , Sasha Levin Subject: [PATCH 6.18 446/957] dmaengine: dw-axi-dmac: Remove unnecessary return statement from void function Date: Wed, 20 May 2026 18:15:29 +0200 Message-ID: <20260520162144.193232887@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Khairul Anuar Romli [ Upstream commit 48278a72fce8a8d30efaedeb206c9c3f05c1eb3f ] checkpatch.pl --strict reports a WARNING in dw-axi-dmac-platform.c: WARNING: void function return statements are not generally useful FILE: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c According to Linux kernel coding style [Documentation/process/ coding-style.rst], explicit "return;" statements at the end of void functions are redundant and should be omitted. The function will automatically return upon reaching the closing brace, so the extra statement adds unnecessary clutter without functional benefit. This patch removes the superfluous "return;" statement in dw_axi_dma_set_hw_channel() to comply with kernel coding standards and eliminate the checkpatch warning. Fixes: 32286e279385 ("dmaengine: dw-axi-dmac: Remove free slot check algorithm in dw_axi_dma_set_hw_channel") Signed-off-by: Khairul Anuar Romli Link: https://patch.msgid.link/20260202060224.12616-4-karom.9560@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index b23536645ff7c..b0e689f48bb67 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -592,8 +592,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set) (chan->id * DMA_APB_HS_SEL_BIT_SIZE)); reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE)); lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0); - - return; } /* -- 2.53.0