From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AFE136D9EA; Wed, 20 May 2026 17:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298810; cv=none; b=j2YMPuU5wU3kG95BKAi+1T3C2OHzfETPAorUiqC6Lu/S9VqRebsqLA/iLGPy2fE7mSvFBVRaImsqWnb6V+Uz+yY+XDJLF/bwersGNSNElj/7H2iEBf7EE11iI1CIirJoItPnI5IglHIlrafE95CJLvFNZLteIEexr4wbIJt0Gso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779298810; c=relaxed/simple; bh=DIPsSIg3+IxYAUXtW/+YH//YNxj/2tLVc6r0S5WRQ8E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PlgAE8PqlnrUScV5MosfJneP0TNFhZFWEhyDz/JHBER9jixFPHaHLBmaLaZDvOIqVer68/sfDn14dy0Z0B6Efr1J+LbUXQjqWfGLVk8Q0dRWvNLport2EWNWGJvgGto21A56YjymfUAEI6gZ22urrMZEb9Rthhy6u3VHFvnfEAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=orCeirWL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="orCeirWL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AABEF1F000E9; Wed, 20 May 2026 17:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779298809; bh=sBOK0ycwWjGKazCVNo7tPePAvbkvULvIJ0nGUeQWAaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=orCeirWLjyYfqIzEJjRKE0Sgp7ZpYdkOFjfeKkOssNmU/wk+KOgPw6QV0TM2wc7g3 z0R5Q8WLtLeDH7Bc9858QMly2KWTlhlXe702yN2XcVep94Vc484/rqKTb2/Zp+GoPP KhnON1NIYM100a+odA2UpAWkrs5hiLuv2ljvDHXU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yang Erkun , Bart Van Assche , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.18 552/957] scsi: sg: Fix sysctl sg-big-buff register during sg_init() Date: Wed, 20 May 2026 18:17:15 +0200 Message-ID: <20260520162146.503892353@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yang Erkun [ Upstream commit 3033c471aaf675254efaa0da431e95d91a104b41 ] Commit 26d1c80fd61e ("scsi/sg: move sg-big-buff sysctl to scsi/sg.c") made a mistake. sysctl sg-big-buff was not created because the call to register_sg_sysctls() was placed on the wrong code path. Fixes: 26d1c80fd61e ("scsi/sg: move sg-big-buff sysctl to scsi/sg.c") Signed-off-by: Yang Erkun Reviewed-by: Bart Van Assche Link: https://patch.msgid.link/20260127062044.3034148-2-yangerkun@huawei.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 57fba34832ad1..c93cc9323f563 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1689,13 +1689,13 @@ init_sg(void) sg_sysfs_valid = 1; rc = scsi_register_interface(&sg_interface); if (0 == rc) { + register_sg_sysctls(); #ifdef CONFIG_SCSI_PROC_FS sg_proc_init(); #endif /* CONFIG_SCSI_PROC_FS */ return 0; } class_unregister(&sg_sysfs_class); - register_sg_sysctls(); err_out: unregister_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0), SG_MAX_DEVS); return rc; -- 2.53.0