From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E513539B483; Wed, 20 May 2026 17:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299656; cv=none; b=sIwJCPr9q/XnOj2aNYCIhWJh9A3nfNt6NdP8pVRVFP5ULGRl0hO3vWNPEprhbu1fyL/X0GAtoHcMFPHBjYoGlc+Fxe5AAFrvVUEElwi1BMO5eSgdkeQGCOMaArCIkTphgseEyAA+5IS9NTSFzkKGIehqbyPIQRke/WCnoL1IR9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779299656; c=relaxed/simple; bh=CfGpJVRqMxOuXPbU0rpc5GA30+/UYNoNDw3KDfpkG1g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MEhAFTk/5G3KcXVIzga4WEI9nsir2SXfiCDbr0UVbbTTP/pqXTZqj7R8iai+PMkTi9Le5FZ72bdHr1hFI37z+ieDUe0RGvZ6pPUqinGBCeURSsckOyqvq4l7s8iGimxzoB5Veq36n3UoS5lHvg0ndh8jRLV1o10dD6r7ehJcl0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sNtKrDLf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sNtKrDLf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 559661F000E9; Wed, 20 May 2026 17:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779299655; bh=DLVYGVIpkN0McsHeIZNFJFl3ByuFmmer6Ur+eAtGm20=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=sNtKrDLfJsOAgkUDEH/sY//tzar0hOni6X1wQx448dlGybaxkRSIHMtG/qOrM884V 4ZZtlE7S3vtGmeHkXzhqZmruECf1f2kAtPlKVJoN5OsnZiongA8/wR4nmcdmJBkiVy 5o8njo/lFOB3Vc3AIx2Bk/5+0SW12i9PyJ4biExk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeremy Kerr , Paolo Abeni , Sasha Levin Subject: [PATCH 6.18 856/957] net/sched: cls_flower: revert unintended changes Date: Wed, 20 May 2026 18:22:19 +0200 Message-ID: <20260520162153.128891774@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162134.554764788@linuxfoundation.org> References: <20260520162134.554764788@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paolo Abeni [ Upstream commit 1e01abec856593e02cd69fd95b784c10dd46880c ] While applying the blamed commit 4ca07b9239bd ("net: mctp i2c: check length before marking flow active"), I unintentionally included unrelated and unacceptable changes. Revert them. Fixes: 4ca07b9239bd ("net: mctp i2c: check length before marking flow active") Reported-by: Jeremy Kerr Closes: https://lore.kernel.org/netdev/bd8704fe0bd53e278add5cde4873256656623e2e.camel@codeconstruct.com.au/ Signed-off-by: Paolo Abeni Link: https://patch.msgid.link/043026a53ff84da88b17648c4b0d17f0331749cb.1777447863.git.pabeni@redhat.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/sched/cls_flower.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index f3af0ac892a86..099ff6a3e1f51 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -560,7 +560,6 @@ static int __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, struct netlink_ext_ack *extack) { struct cls_fl_head *head = fl_head_dereference(tp); - struct fl_flow_mask *mask; *last = false; @@ -577,12 +576,11 @@ static int __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, list_del_rcu(&f->list); spin_unlock(&tp->lock); - mask = f->mask; + *last = fl_mask_put(head, f->mask); if (!tc_skip_hw(f->flags)) fl_hw_destroy_filter(tp, f, rtnl_held, extack); tcf_unbind_filter(tp, &f->res); __fl_put(f); - *last = fl_mask_put(head, mask); return 0; } -- 2.53.0