From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 935913DA7D9; Wed, 20 May 2026 16:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296082; cv=none; b=YKiPhq7D9XeIUM/meV3DkUNrbTGc4nnEj0BVCP9KHTkFvjjJHEFd5tqc7O51sHCqH/sjdwWmBZyaSySCsibDURPahefUlIpGqRNPdcdrL6cY6mfairGpRyQJTI4TEmPOlA9B+tPw/A0LFmzE8AFOrglIla1yOfRHuZwCjf7laLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779296082; c=relaxed/simple; bh=IbxoGcYBdMj92gV8KvEYUjxZzYVxegJX2p6hiGXM6B0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C7RwvtApWzqaloNrees/8lgk5wDiCtK1gov9WoXOkkJEx1taBlY3HjfzdgjSdopRi+xMUzTp8hclNlfGhIpfbcvGvhfs923qoTcEb0GE6/Z0SaycCt5LD/L4jU86g9yuYtnfzTfpcNraSSUZzAS/VTmBJ2dHGPi4K9AG+nBy7gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OlIK5nao; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OlIK5nao" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 017AA1F00893; Wed, 20 May 2026 16:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779296081; bh=90rbFy9F3k717379ZMFgqYzZgfc49FYM3DY688LxlZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OlIK5naovKRxxM0RtWEUj8z7xF22vkHI2YUXnbyEdqwxB8tac87STTDKSd1gZIeOM HsJSvMnqVICE/hP8O/ge6Db9+FX2PDebLrg5WZmmXZnu3ji1Y0ZNX0baKQTAE0DYtK bi+lDb4Kn73syXwNe1ffAD/EXZmqMbGq/TOnBxRs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Rafael J. Wysocki" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 7.0 0665/1146] platform/surface: surfacepro3_button: Drop wakeup source on remove Date: Wed, 20 May 2026 18:15:15 +0200 Message-ID: <20260520162203.237967195@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162148.390695140@linuxfoundation.org> References: <20260520162148.390695140@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rafael J. Wysocki [ Upstream commit 1410a228ab2d36fe2b383415a632ae12048d4f3a ] The wakeup source added by device_init_wakeup() in surface_button_add() needs to be dropped during driver removal, so update the driver to do that. Fixes: 19351f340765 ("platform/x86: surfacepro3: Support for wakeup from suspend-to-idle") Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/4368848.1IzOArtZ34@rafael.j.wysocki Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/surface/surfacepro3_button.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/surface/surfacepro3_button.c b/drivers/platform/surface/surfacepro3_button.c index 9bd39f09c7db4..a6c9d4d370bec 100644 --- a/drivers/platform/surface/surfacepro3_button.c +++ b/drivers/platform/surface/surfacepro3_button.c @@ -242,6 +242,7 @@ static void surface_button_remove(struct acpi_device *device) { struct surface_button *button = acpi_driver_data(device); + device_init_wakeup(&device->dev, false); input_unregister_device(button->input); kfree(button); } -- 2.53.0