From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7573B3603D3; Thu, 21 May 2026 09:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779355368; cv=none; b=blvV2MJPrCxKIjcn44AUbkoi/l1216MoeTubkQ9MvgLUB5SgLpTjVO0N4lf88cOgaGXZeudNVNQ/1pT5INjX7MVoLpxE4/g+zzvjo4vASUw/iFUdKh/YEFDJczXPY3hSajnwggCJKpShkg72AzOh8N8/sMnMqhCwR3gMS0vFhKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779355368; c=relaxed/simple; bh=3A6mIhmiPbTjFnkP8sK3cBDQRcntHVUyGfVZQzb9mL8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UacICMQDWQ6Lad+VGef4Oo7yGNElYuYPWckTJZJdjwBAN4OxFQotmyVavTJswZZMysqEoW+ukflurFzYHAzC4pdZUFM34apR6bMQF/tIXvLvhSCisYEtnLvGhsvyF619Ckh2nTLcdwR00SUkyhk/oBXw593zN29e4qnCT/KluTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DPKbTav5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DPKbTav5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B1D71F000E9; Thu, 21 May 2026 09:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779355367; bh=VzfAW+zwXfiknFx1cDoY0zHG5uJfaAfTzqgYO0QDee4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=DPKbTav5rdmqLfqnEW2A0Kat6i37bTHZ3mTdWMGdbmCEJOaQ++W6Y070QjEwkN3PS 3SGY+Jk2wZuPaOylMGDfyEN8Vt1b6g7MvxMdZCBYTwOvHtzacVqkXZh4SN/Sdnzic+ x1kVbD9VdrJZzNO09rM/l2K4Mnijn+IdfybPYoVY= Date: Thu, 21 May 2026 11:22:50 +0200 From: Greg Kroah-Hartman To: luka.gejak@linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v6] staging: rtl8723bs: fix remote heap info disclosure and OOB reads Message-ID: <2026052142-impart-triumph-e4bd@gregkh> References: <20260514090525.6161-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514090525.6161-1-luka.gejak@linux.dev> On Thu, May 14, 2026 at 11:05:25AM +0200, luka.gejak@linux.dev wrote: > From: Luka Gejak > > When building an association request frame, the driver iterates over > the ies received from the ap. In three places, the driver trusts the > attacker-controlled pIE->length without validating that it meets the > minimum expected size for the respective ie. > > For WLAN_EID_HT_CAPABILITY, this causes an oob read of adjacent heap > memory which is then transmitted over the air (remote heap information > disclosure). For WLAN_EID_VENDOR_SPECIFIC, it causes two separate oob > reads: one when checking the 4-byte oui, and another when copying the > 14-byte wps ie. > > Fix these issues by adding upper-bound checks at the start of the loop > to ensure the ie fits within the buffer, and explicit lower-bound > checks to return a failure if the length is insufficient. For > HT_CAPABILITY, also clamp the length passed to rtw_set_ie() to the > struct size. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Signed-off-by: Luka Gejak More comments: https://sashiko.dev/#/patchset/20260514090525.6161-1-luka.gejak@linux.dev