From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8670A2D0606; Fri, 22 May 2026 20:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779482247; cv=none; b=iRQa791HZejymSHT07Mh6gr9w0rAKhlayR6lx5Kg2GavcuPgzHiHhZUCXNbUXCMJA/KMISg8hVDIIbRoP7YCCgGvXThLafWL5AqMz+Ur3NQdfGFbHs/x6a0jX2kdv/meCAO6HRNcl7cIK6xs7AFHqgDGKb/Ay+U4JkhxWGD1PeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779482247; c=relaxed/simple; bh=QRvxHYP7og2pgk7Qo8770zJ4L8VMB/uKrX0Sa29mc0U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rg5cdFmZzjxj/yagwwUfS0K3fnyp6RzR4CE4SEMS3oL4fAE2KBCTtJv2+W2LDNJ9BrpmtRTRw1gx+Qk6s9829AWZZkRs0c1AosQJEuCzCsRdN7gjmak9opF2kPW4N9sqfMDBc7PCEJxP77UiQPFIAf8PYvnxJe5RQ24GY7Q2FNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LBqU4741; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LBqU4741" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 796DC1F000E9; Fri, 22 May 2026 20:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779482246; bh=bzU0Q2IFmL3yEcw6VeBnpOWCQgHzDgUUj2xNGQbF5RY=; h=From:To:Cc:Subject:Date; b=LBqU4741FtgV5hQkLlt7Tr7kA9RS/N4HEJXH9tUDMu8a/3YjwpCfKFm4LesiumEFS AZvWmxYHzsXqc9+mFn0jeIDRJxtnhj0GD12qjftBP149JrOFzlb4Qq6Zqqo+iuTvGG eAJkcSU1a/0EX36vkUSV23MLXGrBXXssryDzziRvWXrt5uaAxxT0XClPJDnzaz8a0p YfonDUUDfwYBXuAXsXAwx8rK6Ud0pkpYeX/SSrWUDVMdrquEpcHE5Um/ajrjwZRm+w GEm2dUj0gM41OwMNbJrLjQiaViOLhAeT/XGZTU//sKtQjV6fybiDpBs7wlNdXBsyiL i9cJsoxfcdV9g== From: Chuck Lever To: NeilBrown , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: , Chuck Lever , stable@vger.kernel.org Subject: [PATCH v2] nfsd: reset write verifier when async COPY writeback fails Date: Fri, 22 May 2026 16:37:23 -0400 Message-ID: <20260522203723.446841-1-cel@kernel.org> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Async COPY captures nn->writeverf at request time and reports it to the client via CB_OFFLOAD after the worker kthread completes. When the post-copy vfs_fsync_range() or filemap_check_wb_err() in _nfsd_copy_file_range() reports an error, the worker correctly leaves NFSD4_COPY_F_COMMITTED clear so that CB_OFFLOAD encodes wr_stable_how as NFS_UNSTABLE, but the server's write verifier is not rotated. A client that receives NFS_UNSTABLE in CB_OFFLOAD follows up with COMMIT to make the copied data durable. With the verifier unchanged, COMMIT returns the same value the client just received via CB_OFFLOAD, and the client concludes the copy is durable -- silently dropping the data whose writeback in fact failed. This violates the UNSTABLE+COMMIT durability contract (RFC 7862 section 15.1, RFC 8881 section 18.32) and matches the bug just fixed in nfsd_vfs_write() and nfsd_commit(). Rotate nn->writeverf at the writeback-failure site. The async COPY worker has no svc_rqst, so commit_reset_write_verifier() is not available here; calling nfsd_reset_write_verifier() directly mirrors the trace-less reset already used by nfsd_file_check_write_error() for the same purpose. Filter out -EAGAIN and -ESTALE, matching commit_reset_write_verifier(), since neither indicates a durable-storage failure. Fixes: eac0b17a77fb ("NFSD add vfs_fsync after async copy is done") Cc: stable@vger.kernel.org Assisted-by: kres:claude-opus-4-7 Signed-off-by: Chuck Lever --- fs/nfsd/nfs4proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 8561540ab2db..93fcaf90d6ae 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1972,6 +1972,8 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy, status = filemap_check_wb_err(dst->f_mapping, since); if (!status) set_bit(NFSD4_COPY_F_COMMITTED, ©->cp_flags); + else if (status != -EAGAIN && status != -ESTALE) + nfsd_reset_write_verifier(copy->cp_nn); } return bytes_copied; } -- 2.54.0