From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D18750276; Sun, 24 May 2026 12:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779624576; cv=none; b=Z1JYGh1OMsixYEV+0l15Q7lJZvdMqswqAHHasfUtvYCF3J2n8GwnIsRLFy6xE+FVO6rFW5m7bggZ1R3muW+6GchXLxXk67RvLYG7a6GiV5psEs8B0pCczlDM9Va2w7pyigfQiTS6BNHKYZOXQMOuJOv8qZnqDGsCtF2OYeuuNVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779624576; c=relaxed/simple; bh=JYLca4n8uqZO9kcR5Hs/dt+SiHjgiTMVx0T3+SlFIHE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ds61iEFpU90AVhg1TfragwvV3xGwrZb3TPy9Bmy8zmIytnvbB7WBsveC5t9e3Q2rYs7jElzO+wTQe5l9NKl/jy24SURH2hoVvSGTV1exFXfHt0ihZHWRqEQUu45cOEPJ4MaFoD7/leY25xEQYELpD18HQlWktp22QUM6xxAsCek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EWvyNaMn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EWvyNaMn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA7D81F000E9; Sun, 24 May 2026 12:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779624575; bh=x0pitH5PkhGEQgtkB/Mc6awN6Q5lzEr649KS/2bWQtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EWvyNaMnxKQfxBoEvQW0soT9eIVljDvikuHOkfNGrCSQs4GYJnSjZV8ObfDZh7pNI GedWm5w8JB+rdEnxu/1lib8xvE7k7ZmN4NRZ0dO8m/SBhC6t9xX8txS2/cnPia0YLU +OHd7/3HumRldSuduO4uWhGwUwNJ1PEn8hGFyvMGFUNC9jhAvHFS4KsOllyzEQ9Kk5 U79PCWzZF2g2s41HR4SyaOb/8ZpN8AfHrdnoPxL+IWZKuNLekPmNH3BYu+Vt2YF3qH ahtG/kE97YrG+bGu31uCXusSKcHnmN1pDk42GQ8vApko+iZODpBYXL96a8kKyT0h8E cNMcSTQxCvi8w== From: Sasha Levin To: stable@vger.kernel.org Cc: Sasha Levin , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Binns , Matt Coster , Brajesh Gupta , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alessio Belle Subject: Re: [PATCH 6.12.y] drm/imagination: Synchronize interrupts before suspending the GPU Date: Sun, 24 May 2026 08:09:28 -0400 Message-ID: <20260524-stable-item014-reply@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522-sync-irqs-6-12-v1-1-b0ecc9675078@imgtec.com> References: <20260522-sync-irqs-6-12-v1-1-b0ecc9675078@imgtec.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > commit 2d7f05cddf4c268cc36256a2476946041dbdd36d upstream. > > The runtime PM suspend callback doesn't know whether the IRQ handler is > in progress on a different CPU core and doesn't wait for it to finish. > [...] > This version of the patch contains only the part of the upstream commit > that applies to 6.12; the rest was a revert of code added in 6.16. The diff itself is fine and the synchronize_irq() portion is exactly what we want on 6.12.y. However, the backport drops several trailers from the upstream commit that we'd like to preserve verbatim on stable: - Reviewed-by: Matt Coster - Link: https://patch.msgid.link/... (the upstream Link: trailer) - Signed-off-by: Matthew Brost (the upstream maintainer SoB that landed the patch upstream) The upstream Fixes: tag also lists two entries: Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware ...") Fixes: 96822d38ff57 ("drm/imagination: Implement Rogue safety event IRQs") Your backport keeps only the first. I agree the second Fixes: refers to code that doesn't exist on 6.12, but please keep it in the commit message anyway so the trailers match upstream verbatim; stable convention is to preserve the upstream trailer block unchanged. Could you send a v2 with the upstream trailers (Reviewed-by, Link, SoB, both Fixes:) restored? -- Thanks, Sasha