From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B56CF2F1FEC; Thu, 28 May 2026 20:35:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780000516; cv=none; b=l3antitmqmz/jbnYliSSsWevW2kgbdPAVCNjHgNl7mzMyxfFOvgvX4N05y1bB+5gBQQmy3ynBQHqk5pxCkVLLhL8Gm4s73bZoxRBrD2QhpBh0en15O7E54urDMl29tYrbs4PRsPFKBshNM5vLTAW6XqKmG73UDOCgzGy7oyqTrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780000516; c=relaxed/simple; bh=t5qBVfxB+vaKVnHuwzHTjBmE9E3/QpZTrTS6R/iCN+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IoJ4hOxpXoVPPILQBZKTaqeJaj2A6Mi3S+JybEAohUjEYWQ0zaOFDwhXmUSFixzwOy4qQeGOTZKv9ouQkgbWyNvg+BPInidJq2pBqrO0wQFEHnmEutBEOiReRjwKToBao1r5+fDwgnN5n8+iiflN1Z78M4luI1Ak7fY3wPdgqHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mRsE8PCu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mRsE8PCu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FFE21F000E9; Thu, 28 May 2026 20:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780000515; bh=B60jo4d5Feex9bb7y9ZphFDDoW95xlynNyrSDcdaLR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mRsE8PCudfBAUF4V9lnFwHJc605i+L+qu3PX6W84+1x/hYfYk2z593stdgrYVzbEs nhgM76tzllmTzRZBxBC5jxdjseeszuUN7hffBmdqKI7GuaG6sn+wsLLWhPqZCreIqM UThQ73tnUdQrBFdHCWX7sM8w9Iiv3YmjQXZOxTRU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jonas Jelonek , Oleksij Rempel , Jakub Kicinski Subject: [PATCH 6.12 072/272] net: pse-pd: fix sign on -ENOENT check in of_load_pse_pis() Date: Thu, 28 May 2026 21:47:26 +0200 Message-ID: <20260528194631.391750661@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528194629.379955525@linuxfoundation.org> References: <20260528194629.379955525@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jonas Jelonek commit 33d35975cbead3fa6b738ee57e5e45e14fbe0886 upstream. of_count_phandle_with_args() returns the count on success and a negative errno on failure, including -ENOENT when the "pairsets" property is absent. The existing comparison in of_load_pse_pis() checks against ENOENT (positive 2) instead of -ENOENT, so the branch is taken for any error return: legitimate DTs that omit "pairsets" trigger a spurious "wrong number of pairsets" error and probe fails with -EINVAL. Compare against -ENOENT so a missing "pairsets" property is correctly treated as "this PI has no pairsets, continue". Fixes: 9be9567a7c59 ("net: pse-pd: Add support for PSE PIs") Cc: stable@vger.kernel.org Signed-off-by: Jonas Jelonek Acked-by: Oleksij Rempel Link: https://patch.msgid.link/20260515143103.1721888-1-jelonek.jonas@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/pse-pd/pse_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/pse-pd/pse_core.c +++ b/drivers/net/pse-pd/pse_core.c @@ -184,7 +184,7 @@ static int of_load_pse_pis(struct pse_co ret = of_load_pse_pi_pairsets(node, &pi, ret); if (ret) goto out; - } else if (ret != ENOENT) { + } else if (ret != -ENOENT) { dev_err(pcdev->dev, "error: wrong number of pairsets. Should be 1 or 2, got %d (%pOF)\n", ret, node);