From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54FE3257854; Thu, 28 May 2026 20:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999704; cv=none; b=AZ8lt07xSq/6N4NgEhkhARHk2tPYxQCFxEo7WPf1lPGe7wqhzu2Omf7Ker7OzVaKqPV8CCOxxpnI3Wo1HfJoJgNb/O5noA6QMh/A7yxOBm5g5oCfzAiaZ/Q5AEUxfQDxFE5zcnmV0/3bSE0UjZPPFVMNFveTqrn7nWofX6u7EZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999704; c=relaxed/simple; bh=0M6CZVS5Ey2yNnD2+cm8P/tpwuP1DhOfTJldUVJlF6A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S5xPSdzIHDy6pdpuse/5qYunRSL9TZDsWDPwb2iGIjI//VtrXuOwccErbFZlBaEX2E/amfrMqdawPrDMPwAzhJNrdkVWg7aHZJV6cRKtv56BsVJju2aAdvAmZvZWtT9R2bOvGNiW4ny7aR4qWy8AW115t0e5WrrLXHBktOgRZ6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=i3QuogIx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="i3QuogIx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D39A1F00A3C; Thu, 28 May 2026 20:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779999702; bh=eDsRRaye4cH7Z9lMit0Utxb9mIbsRtwoYwPd1oxHt8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=i3QuogIxrccgqt1iPYBNz1Er8cVD+sZ02jPF+yfBSoMjSmTCG0Hptdic0JhDYlhRD zowXo5mcDuicF0f34IwewW7oZ+jc/V1K4miSu/IIFVFHXwhS7A126nj3t9wiAaVUeG Zg9pN12gCKiht8fvXj60pZ0PeUBE/RGU0VcUZjlE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdurrahman Hussain , Guenter Roeck Subject: [PATCH 6.18 162/377] hwmon: (pmbus/adm1266) reject implausible blackbox record_count Date: Thu, 28 May 2026 21:46:40 +0200 Message-ID: <20260528194643.115667860@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528194638.371537336@linuxfoundation.org> References: <20260528194638.371537336@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdurrahman Hussain commit 4afca954622d672ea65ed961bed01cf91caa034e upstream. adm1266_nvmem_read_blackbox() loops over a record_count that comes straight from byte 3 of the BLACKBOX_INFO response. The destination buffer is data->dev_mem, sized for the nvmem cell's declared 2048 bytes (ADM1266_BLACKBOX_MAX_RECORDS * ADM1266_BLACKBOX_SIZE = 32 * 64). A device that reports a record_count greater than 32 -- whether due to firmware bugs, bus corruption, or a non-responsive slave returning 0xff -- would walk read_buff past the end of the dev_mem allocation on the trailing iterations. Cap record_count at ADM1266_BLACKBOX_MAX_RECORDS (introduced here) before entering the loop and return -EIO on any larger value, so a malformed BLACKBOX_INFO response cannot drive the loop out of bounds. Fixes: 15609d189302 ("hwmon: (pmbus/adm1266) read blackbox") Cc: stable@vger.kernel.org Signed-off-by: Abdurrahman Hussain Link: https://lore.kernel.org/r/20260515-adm1266-fixes-v1-3-1c1ea1349cfe@nexthop.ai Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/pmbus/adm1266.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/hwmon/pmbus/adm1266.c +++ b/drivers/hwmon/pmbus/adm1266.c @@ -46,6 +46,7 @@ #define ADM1266_BLACKBOX_OFFSET 0 #define ADM1266_BLACKBOX_SIZE 64 +#define ADM1266_BLACKBOX_MAX_RECORDS 32 #define ADM1266_PMBUS_BLOCK_MAX 255 @@ -360,6 +361,8 @@ static int adm1266_nvmem_read_blackbox(s return -EIO; record_count = buf[3]; + if (record_count > ADM1266_BLACKBOX_MAX_RECORDS) + return -EIO; for (index = 0; index < record_count; index++) { ret = adm1266_pmbus_block_xfer(data, ADM1266_READ_BLACKBOX, 1, &index, read_buff);