From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CE1B33CE8A; Thu, 28 May 2026 19:55:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779998111; cv=none; b=Bbl08u5915B/bLwE4HKGmK9TjHwA0A4O6m/EWGfky1A2ZJuqD04HtYFDBfVH9+iY+U/Lf4UWyVEISyNz2mOH067Bpjihp3TiNuG+jjlRcJ8B5eFmY6EtCQjpu63vcrixp0RSNY1zviCBhtDNMfaI+nLzFX8YqNe2n7Rr/d4Rx+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779998111; c=relaxed/simple; bh=2LZJXPmdyhK9lbQopw1ee5Hy5KbyLjd+LJw0jMPNVNo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OmcLiz9LK6qukadPV8ujhohFz3j2ua/Ppuhro8bGbeowIzHj2YXZ+LvZ7V61CzpUN8hv6qFXL9QVSPoWxop6wsjh2onwBVo8IRsX65rCWDF4QtggVtIoereO3pdlK1an/AldEmxWNf/RPJMlClBDRJI4zWodS58J6DsHLyKakN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=p3D9gW+w; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="p3D9gW+w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E14EA1F000E9; Thu, 28 May 2026 19:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779998110; bh=AVV+AUVZGVZg4/coqcpLluX8T7s04rhWVzZKk3V0WdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=p3D9gW+wLsj1kJ0cWqPQ0UgIR9UfETvmIP+2XsiMdVGD7UrNP3nP7hy1rakkcCO6h ZEWMibFkVy4KYMFxn1Unsh9AcmNWJoRfAqOUKMlaXfpeczWEUrlwplIO9/Km603NeF PetvCfYzdtd0Pf+RyDjCHXZFPk/PSgZi1J6JxyYA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Yuan Tan , Yifan Wu , Juefei Pu , Xin Liu , Zhengchuan Liang , Ren Wei , Pablo Neira Ayuso Subject: [PATCH 7.0 057/461] netfilter: ip6t_hbh: reject oversized option lists Date: Thu, 28 May 2026 21:43:06 +0200 Message-ID: <20260528194648.561804854@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528194646.819809818@linuxfoundation.org> References: <20260528194646.819809818@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhengchuan Liang commit 4322dcde6b4173c2d8e8e6118ed290794263bcc8 upstream. struct ip6t_opts stores at most IP6T_OPTS_OPTSNR option descriptors, but hbh_mt6_check() does not reject larger optsnr values supplied from userspace. Validate optsnr in the rule setup path so only match data that fits the fixed-size opts array can be installed. This follows the existing xtables pattern of rejecting invalid user-provided counts in checkentry() and keeps the packet matching path unchanged. `struct ip6t_opts` has a fixed `opts[IP6T_OPTS_OPTSNR]` array, where `IP6T_OPTS_OPTSNR` is 16, then off-by-one array access is possible: [ 137.924693][ T8692] UBSAN: array-index-out-of-bounds in ../net/ipv6/netfilter/ip6t_hbh.c:110:29 [ 137.926167][ T8692] index 16 is out of range for type '__u16 [16]' Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Xin Liu Signed-off-by: Zhengchuan Liang Signed-off-by: Ren Wei Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/ipv6/netfilter/ip6t_hbh.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/net/ipv6/netfilter/ip6t_hbh.c +++ b/net/ipv6/netfilter/ip6t_hbh.c @@ -168,6 +168,10 @@ static int hbh_mt6_check(const struct xt pr_debug("unknown flags %X\n", optsinfo->invflags); return -EINVAL; } + if (optsinfo->optsnr > IP6T_OPTS_OPTSNR) { + pr_debug("too many supported opts specified\n"); + return -EINVAL; + } if (optsinfo->flags & IP6T_OPTS_NSTRICT) { pr_debug("Not strict - not implemented");