From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6585833F5BE; Thu, 28 May 2026 20:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999209; cv=none; b=cJ5GQsSSR8CNRA9NZjULTxEl7XecUZzHD++GjgV4nufQJg5kP3kY3ctXgDhtqZ+ZZc2lfAZEWC0mJhOIcH7NIrIXJZuVxH/gpZFMDF7Q+CEQaLZLI3/lVkPbcmcd1Udkq12r9BcKkyHkJqJeecQniwaJbaQG/cNFIdLiw5MuoOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999209; c=relaxed/simple; bh=b0n7O6Ey3xlpJkw+FA+TxroFyp+VjoWHAiPnXIdsCgA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nsMMAKPnAgAaNKGoBznx1q6bmYEiG0j6D0qErkkLLsbZaFDI3EzxmSvktFJ3km/KGoyU4Zq78uvHSmnvB9GlRivWMlVfzL9+ZLQJ/VAHLTsdRfvQ1KGJtYp7o3kE1PT5+8FUSrGfACo+3LWJ8rb4hTHoHEyZ9vJMMrDM10EZ4O4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QVCELfp1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QVCELfp1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2AE21F000E9; Thu, 28 May 2026 20:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779999208; bh=EBhqrIahQAfWA8wUIeIo4JXJpiS2y5OFwCitB5GFrI0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QVCELfp1h7+xEvFEo800DkljFp5F4BcEtGLoUiVLFT2nkB4ENDQN4Ti8JyJThyB/9 LCWZOnH5583AcGXWh6e6ZkX7FappHqENSwi99U7e7q6O0CuzG/z/GTYhQtbZ/Ai4OI uJLpV/U/tW/Rh3DiCT2JhnyXcAb3c/4Vv/cyg1FY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Geetha sowjanya , Ratheesh Kannoth , Jakub Kicinski , Sasha Levin Subject: [PATCH 7.0 448/461] octeontx2-af: npc: Fix allmulticast skip logic for LBK and SDP VFs Date: Thu, 28 May 2026 21:49:37 +0200 Message-ID: <20260528194700.505359837@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260528194646.819809818@linuxfoundation.org> References: <20260528194646.819809818@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ratheesh Kannoth [ Upstream commit 9eddc819f00b5b74bb4ac91396f80bd35f5f3561 ] When installing the allmulticast NPC rule, rvu_npc_install_allmulti_entry() should skip LBK and SDP VFs (only CGX PF/VF may add the entry). The code combined is_lbk_vf() and is_sdp_vf() with logical AND, which is never true for a single pcifunc, so the intended early return never ran. Use logical OR instead. Cc: Geetha sowjanya Fixes: ae703539f49d2 ("octeontx2-af: Cleanup loopback device checks") Signed-off-by: Ratheesh Kannoth Link: https://patch.msgid.link/20260520043036.1523798-1-rkannoth@marvell.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c index 8658cb2143dfc..e28675fe18907 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c @@ -837,7 +837,7 @@ void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf, u16 vf_func; /* Only CGX PF/VF can add allmulticast entry */ - if (is_lbk_vf(rvu, pcifunc) && is_sdp_vf(rvu, pcifunc)) + if (is_lbk_vf(rvu, pcifunc) || is_sdp_vf(rvu, pcifunc)) return; blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0); -- 2.53.0