From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F9F27FD43 for ; Thu, 28 May 2026 13:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976348; cv=none; b=Dd0rq4ufWMg0IMDkOR8+5CmEiSOLyeCyV2JC93HB/diek/m01JVZAqX4FfnMsYANVIfU1DQjfZDMynGLTHEpV46U8/Ru2Mrh1/azC8T5oUn7wWxUB91cQv3HpS3Yve+7WAjNbbuS2HQmyvY3hhekllk+6iQVenbdrIvi8XUWAVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976348; c=relaxed/simple; bh=dDgyDHkM1D1QfQki4JsmKAOCsuLQQ23K38ELlnF5LlQ=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=tapO+4rf/0qNCs52SDOrrghMbvCARvNsRG9XrnXnd6+P7kntjzQFXRZo9LxezkpzXCzlkrZtS4kNkLRPADq2LoGPdedd7a1jiUZm2wyME+c3pUPFyk3kRPbIyX2bH6C30WIB60kkHjQtbpludyEdHmJEgYC0tD1z6ZZ44g1a1Vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EqZD1m0g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EqZD1m0g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6288F1F000E9; Thu, 28 May 2026 13:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779976346; bh=MnwIceuqAfDwEk45JdupuQAar/ex1QUySty2LzcFdWk=; h=Subject:To:Cc:From:Date; b=EqZD1m0gE8AuzwVWro/MCEC+NMe3ARwawZT+DNOATrBL/P0Osk4+QmdjqHYwGKgUC kAXekUNfyM0N3BpyXEqp6PvNncloP3a1M7Xt7hF5mCoOBTMENcgln6KWntby458/2B BINdKD/Bm1IkiiOk3gHaThQItoZlzmLoz4nw1/+Y= Subject: FAILED: patch "[PATCH] hwmon: (pmbus/adm1266) serialize sequencer_state debugfs read" failed to apply to 6.18-stable tree To: abdurrahman@nexthop.ai,linux@roeck-us.net Cc: From: Date: Thu, 28 May 2026 15:51:23 +0200 Message-ID: <2026052823-ending-creation-bc11@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 4e4af55aaca7f6d7673d5f9889ad0529db86a048 # git commit -s git send-email --to '' --in-reply-to '2026052823-ending-creation-bc11@gregkh' --subject-prefix 'PATCH 6.18.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 4e4af55aaca7f6d7673d5f9889ad0529db86a048 Mon Sep 17 00:00:00 2001 From: Abdurrahman Hussain Date: Mon, 18 May 2026 17:52:32 -0700 Subject: [PATCH] hwmon: (pmbus/adm1266) serialize sequencer_state debugfs read with pmbus_lock adm1266_state_read() backs the sequencer_state debugfs entry and issues an i2c_smbus_read_word_data(client, ADM1266_READ_STATE) against the device without taking pmbus_lock. pmbus_core holds pmbus_lock around its own multi-transaction sequences (notably the "set PAGE, then read paged register" pattern used by hwmon attributes), so an unlocked debugfs reader can land between a PAGE write and the subsequent paged read in another thread. READ_STATE itself is not paged, so it cannot corrupt PAGE in flight, but the same defensive serialisation that applies to the GPIO accessors applies here: any direct device access from outside pmbus_core should be ordered with respect to pmbus_core's own. Take pmbus_lock at the top of adm1266_state_read() via the scope-based guard(). Fixes: ed1ff457e187 ("hwmon: (pmbus/adm1266) add debugfs for states") Cc: stable@vger.kernel.org Signed-off-by: Abdurrahman Hussain Link: https://lore.kernel.org/r/20260518-adm1266-gpio-fixes-v3-8-e425e4f88139@nexthop.ai Signed-off-by: Guenter Roeck diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c index 5ddca5701032..6f6ad7b20e9a 100644 --- a/drivers/hwmon/pmbus/adm1266.c +++ b/drivers/hwmon/pmbus/adm1266.c @@ -335,6 +335,7 @@ static int adm1266_state_read(struct seq_file *s, void *pdata) struct i2c_client *client = to_i2c_client(dev); int ret; + guard(pmbus_lock)(client); ret = i2c_smbus_read_word_data(client, ADM1266_READ_STATE); if (ret < 0) return ret;