From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A46A83F44DE for ; Thu, 28 May 2026 13:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779975023; cv=none; b=hbVnUJ3eetKqIfb775Uw9OGwAOtldU2saS4ElrJohl8tT2/AUzTIAIxnQYEQ6ZR8M/WV/XkI091h3oQ2YtnViWOfGBxjDDp2fRgzxJxr70IxNTbUMYWZqy5aSR7TSV7hbJqyeWxB/8CxcQRWNGiDMrW/eWoug3hAZ/tZWK37S0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779975023; c=relaxed/simple; bh=OSyIVnroV7UcKmZElSHpYOi0FomPQEZO/eHjkTjgA68=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=O+tivtGgeLkembMiE9+Jk0o2vLuuFobRJi+9jfFm3TVf9DhHVGrmsqVq4tgB3hVONEWovsYS/2YJdaCdKbd+JkViGJxb4ymo6UJHBj8iUFr9nFDMLKgkHsTS7Oo4rrAK9gm4Y8TOQADQgwwfob+ETiz1JyUmlS0/VJx+8ICMPR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0dUryWph; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0dUryWph" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70E9A1F000E9; Thu, 28 May 2026 13:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1779975020; bh=HKhRO7GD7p/6oeNgduJTTv0iEv/YHM+W0x143pbd56I=; h=Subject:To:Cc:From:Date; b=0dUryWphXH1T/3tq/9v79IVFTNdNVWO5jqiHvRGlLe/R1MpRHPt3QqZ4+dSszPgRS 44s2zx6Iae50cHvIWyuxYT0YWyise4+UD5mfgpMP3UtSnQNd05uaP7xLu+r36zBtrq hCoLfs8D8pJwx0XlEpPcFaMr5svBf+OnMDEKcRdU= Subject: FAILED: patch "[PATCH] hwmon: (pmbus/adm1266) serialize NVMEM blackbox read with" failed to apply to 5.10-stable tree To: abdurrahman@nexthop.ai,linux@roeck-us.net Cc: From: Date: Thu, 28 May 2026 15:29:27 +0200 Message-ID: <2026052827-elective-eraser-5e4e@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 9f1dd8f9491eb840cbea7ffdf4cad031e25f8ae0 # git commit -s git send-email --to '' --in-reply-to '2026052827-elective-eraser-5e4e@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 9f1dd8f9491eb840cbea7ffdf4cad031e25f8ae0 Mon Sep 17 00:00:00 2001 From: Abdurrahman Hussain Date: Mon, 18 May 2026 17:52:31 -0700 Subject: [PATCH] hwmon: (pmbus/adm1266) serialize NVMEM blackbox read with pmbus_lock adm1266_nvmem_read() is the reg_read callback the NVMEM core invokes when userspace reads /sys/bus/nvmem/devices/.../nvmem on this chip. On the first byte of every read it does a memset of data->dev_mem, walks the device blackbox through adm1266_nvmem_read_blackbox() (which issues a chain of PMBus block transactions), and then memcpys the refreshed buffer out to userspace. None of that runs under pmbus_lock today. Two consequences: - The PMBus traffic the refresh issues is not serialised against pmbus_core's own multi-step PAGE+register sequences. A paged hwmon attribute read from another thread can land between a PAGE write and the paged read in either direction and corrupt one side's view of the device state machine. - The NVMEM core does not serialise concurrent reg_read calls, so two userspace readers racing at offset 0 can interleave the memset of data->dev_mem with another reader's adm1266_nvmem_read_blackbox() refill or memcpy out, returning torn data to userspace. Take pmbus_lock at the top of adm1266_nvmem_read() via the scope-based guard(). Patch 5 of this series moves adm1266_config_nvmem() past pmbus_do_probe() so the lock is guaranteed to be live before the callback is reachable from userspace. Fixes: 15609d189302 ("hwmon: (pmbus/adm1266) read blackbox") Cc: stable@vger.kernel.org Signed-off-by: Abdurrahman Hussain Link: https://lore.kernel.org/r/20260518-adm1266-gpio-fixes-v3-7-e425e4f88139@nexthop.ai Signed-off-by: Guenter Roeck diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c index 0eef58dd69a6..5ddca5701032 100644 --- a/drivers/hwmon/pmbus/adm1266.c +++ b/drivers/hwmon/pmbus/adm1266.c @@ -400,6 +400,8 @@ static int adm1266_nvmem_read(void *priv, unsigned int offset, void *val, size_t if (offset + bytes > data->nvmem_config.size) return -EINVAL; + guard(pmbus_lock)(data->client); + if (offset == 0) { memset(data->dev_mem, 0, data->nvmem_config.size);