From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4195F2E4257 for ; Fri, 29 May 2026 02:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780022676; cv=none; b=WENDxr5DCpodAY17omAhzq0PYMLx6kbtC9WwjxS60KTasOxl07ajzrJRZ04dNNf7p5TR8w5HeShpN/M46JnOR7uHYGkzrsVMqVchcD19Mre98Hurkc7NQrY9pKDaIJZfTr0uJCUWbI8tvRdPgXF+4zDcv5BsEbaZ77yLHgOeChE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780022676; c=relaxed/simple; bh=ERCUu0OTKyBW7d8BDg6b1CCWGXh2afeMFLXTgY0V+mg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KmfJz4e6QjHcWzaTVtS7RyyO647vdQXv9mfrMBR5YpN/gfPUvddcHIu49EhbWXzHk3js6sgoQgSIePL5QLxuEIsHfJzjMBjpdql5XO1znk2SqS/IRXdGhThgknBeVkGRDuuUUa9it7pCq46OsMRdRGEk1OXff3HcQ/boc9G8WmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LpnB7SEt; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LpnB7SEt" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso116520845e9.2 for ; Thu, 28 May 2026 19:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780022674; x=1780627474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PIeeAegIg2JykmlVBizWFPwVLHaIF4C+HMP59JRPEVg=; b=LpnB7SEtNAgAxeG+fxGILewB3ONlmgQGuMFJxyotYLDUmyjKyb8345cyLw2ktPTmpl wUQrFgwQD3FR/nMVjcuSm85RB7u39/AcO+WpOIs3cw5aCPL0Oq+QXb3ofctsR6613Qxa 2btHsoJot3VqOPRVXdsSt3c/YRngAKMDjjOsPDcEErwOhnRxFxexkTK5KI8u6qbqK1Ux v2CjvB4GrVA1Rcepnv3Rbt5DwTK9lhkIxUTs79axnkBl91/FzxclijwxQl+J18VvXke0 W7myMVcv7gVuqdq3Xs3hJtseWAfZmPh50VZEJ9AfR8ey22EbjN+1M1TA5Emat/k7BVw7 A/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780022674; x=1780627474; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PIeeAegIg2JykmlVBizWFPwVLHaIF4C+HMP59JRPEVg=; b=eBKI1x0RdyT0OICwkoctvIJQ87esVdNxS+kzf+VNjzj9Z22PXxixakX1wPr7/S6zEg tUVJVMw/GN/tcppRCGD5Ypa1/yYxZ5ZoZQl428x5D7O7DA+XAr6FbRs11184ZEq71v31 3y1eIyg9f3JBZbHe4kGu5D96X0YXF1HhH7kQp3L/3z4iNlVDb+c9j4loDj2v+OEcROjR T3kLr77RpIuVnT+UhbL/9tCGKLPfHPscrK45TlAwzVUSs68pV2AmHPqYQVWUMJH3Jzgu 4HOT5q9GaOBi5CjqSRaGA8jjnA2FyjVCpnDnGBBaxkxv0TmrIIAQ7sEED+3d5A7nvgf1 /x7w== X-Forwarded-Encrypted: i=1; AFNElJ+LM3xy4GGenA10u0mmwElNY+8irWyBZGyKDD5Z7ap33lpGWsj2aPsU74bkMc3CZu+xq7EiEiI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1q9foRDnEHPAhRatjFhINCTOwej92h/QTapRI1QuD6eFcpOy/ KZN7+AJTozXEYLzNMz1f8g52crbX1nDyZD3bAPdJA1ZVGhwjzayxljRt X-Gm-Gg: Acq92OGu1QELmdvj6OVfNk18viYKua7x8NsPMO9ymluH27NWxSf2VMnn5+JxWJvsgwq cAcww6m8XdIrnoIE46k1qUUIuchQNVaO013kD9A1MKvnZm4Ec51IgA4aXy2DVd9egc9lyQ5U8XF 327DN82t3eTESrVbrzUbXLvtTYKmgm/LZcdvrKATcS8jm0YtOooULiiOEgkw2mj0jyXwpZ6FviP 8foJO9X5FQV3uA2mZn5ck1+6RppKfc9kvwFK0QspUeHoSnAQtVt7C67+XUwpTM0wdfzuGS5Kct6 UG2uNRgJsbe8/aphO+VxW/AtL/uYn9SvR5EZM4yuBxL9Vey3pEcNr68J8l1tAuJ/70Hc3JnAWV6 ++h8BNJfO3uyp4rkLmD60zbPql1RmKp6GqH7fJIsPmiCu+B1qGVGKEOI68T6sTeFj/PmhBICoFO NuwAVMGQka0qUoxqsV7QggPAlFV++bEwIkPGKemV2ZwW8cz8bnkgtf5XZa+xIjLIaP3jmw1vHJh NtrxLFHUi98e/5Tc3UMww== X-Received: by 2002:a05:600c:e489:20b0:490:6869:46c6 with SMTP id 5b1f17b1804b1-4909c0c3aa4mr10788265e9.31.1780022673514; Thu, 28 May 2026 19:44:33 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34a065esm178139f8f.5.2026.05.28.19.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 19:44:32 -0700 (PDT) From: David Carlier To: Daniel Scally , Jacopo Mondi Cc: Mauro Carvalho Chehab , Hans Verkuil , Nayden Kanchev , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Carlier Subject: [PATCH] media: mali-c55: fix integer overflow in scaler factor calculation Date: Fri, 29 May 2026 03:44:29 +0100 Message-ID: <20260529024429.6942-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The scaling factors are computed by multiplying the crop dimension by the Q4.20 unit (1 << 20) and dividing by the output dimension. The results are stored in u64, but both operands are 32-bit, so the product is evaluated in 32-bit arithmetic and only widened afterwards. Crop dimensions may be up to 8192. Once a dimension reaches 4096 the product overflows 32 bits and wraps (zero at exactly 4096), programming a corrupted scaling increment and corrupting the downscaled output. Define the fixed-point unit as unsigned long long so the multiplication is done in 64-bit arithmetic. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- drivers/media/platform/arm/mali-c55/mali-c55-resizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c b/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c index c4f46651dcee..182a1b19def4 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c @@ -15,7 +15,7 @@ #include "mali-c55-registers.h" /* Scaling factor in Q4.20 format. */ -#define MALI_C55_RSZ_SCALER_FACTOR (1U << 20) +#define MALI_C55_RSZ_SCALER_FACTOR (1ULL << 20) #define MALI_C55_RSZ_COEFS_BANKS 8 #define MALI_C55_RSZ_COEFS_ENTRIES 64 -- 2.53.0